[flow][records] Add custom parse error for using computed property in record

Summary:
Add custom parse error for using computed property in record.

Changelog: [internal]

Reviewed By: panagosg7

Differential Revision: D87111849

fbshipit-source-id: 448d3541087a13536ec40e70a476a091ccb38db5

Author: gkz

src/parser/object_parser.ml

@@ -1211,6 +1211,15 @@ module Object
           Eat.token env;
           error_at env (error_loc, Parse_error.RecordPrivateElementUnsupported)
         );
+        if Peek.token env = T_LBRACKET then (
+          let start_loc = Peek.loc env in
+          Expect.token env T_LBRACKET;
+          ignore @@ Parse.assignment (env |> with_no_in false);
+          let end_loc = Peek.loc env in
+          Expect.token env T_RBRACKET;
+          let error_loc = Loc.btwn start_loc end_loc in
+          error_at env (error_loc, Parse_error.RecordComputedPropertyUnsupported)
+        );
         let key = identifier_name env in
         let (key_loc, { Identifier.name = key_name; _ }) = key in
         let check_invalid_name env ~method_ =

src/parser/parse_error.ml

@@ -127,6 +127,7 @@ type t =
   | PrivateDelete
   | PrivateNotInClass
   | PropertyAfterRestElement
+  | RecordComputedPropertyUnsupported
   | RecordExtendsUnsupported
   | RecordInvalidPropertyName of {
       name: string;
@@ -446,6 +447,7 @@ module PP = struct
     | PrivateDelete -> "Private fields may not be deleted."
     | PrivateNotInClass -> "Private fields can only be referenced from within a class."
     | PropertyAfterRestElement -> "Rest property must be final property of an object pattern"
+    | RecordComputedPropertyUnsupported -> "Records do not support computed properties."
     | RecordExtendsUnsupported ->
       "Records to not support `extends`: they do not allow hierarchies. Implementing an interface by using `implements` is supported."
     | RecordInvalidPropertyName { name; static; method_ } ->

src/parser/test/flow/records/records-computed-properties-unsupported.js

@@ -0,0 +1,3 @@
+record R {
+  [X]: number,
+}

src/parser/test/flow/records/records-computed-properties-unsupported.options.json

@@ -0,0 +1,3 @@
+{
+  "records": true
+}

src/parser/test/flow/records/records-computed-properties-unsupported.tree.json

@@ -0,0 +1,113 @@
+{
+  "errors":[
+    {
+      "loc":{"source":null,"start":{"line":2,"column":2},"end":{"line":2,"column":5}},
+      "message":"Records do not support computed properties."
+    },
+    {
+      "loc":{"source":null,"start":{"line":2,"column":5},"end":{"line":2,"column":6}},
+      "message":"Unexpected token `:`, expected an identifier"
+    },
+    {
+      "loc":{"source":null,"start":{"line":2,"column":7},"end":{"line":2,"column":13}},
+      "message":"Unexpected identifier, expected the token `(`"
+    },
+    {
+      "loc":{"source":null,"start":{"line":2,"column":13},"end":{"line":2,"column":14}},
+      "message":"Unexpected token `,`, expected an identifier"
+    },
+    {
+      "loc":{"source":null,"start":{"line":3,"column":0},"end":{"line":3,"column":1}},
+      "message":"Unexpected token `}`, expected the token `,`"
+    },
+    {
+      "loc":{"source":null,"start":{"line":4,"column":0},"end":{"line":4,"column":0}},
+      "message":"Rest parameter must be final parameter of an argument list"
+    },
+    {
+      "loc":{"source":null,"start":{"line":4,"column":0},"end":{"line":4,"column":0}},
+      "message":"Unexpected end of input, expected the token `)`"
+    },
+    {
+      "loc":{"source":null,"start":{"line":4,"column":0},"end":{"line":4,"column":0}},
+      "message":"Unexpected end of input, expected the token `{`"
+    },
+    {
+      "loc":{"source":null,"start":{"line":4,"column":0},"end":{"line":4,"column":0}},
+      "message":"Unexpected end of input, expected the token `}`"
+    }
+  ],
+  "type":"Program",
+  "loc":{"source":null,"start":{"line":1,"column":0},"end":{"line":4,"column":0}},
+  "range":[0,28],
+  "body":[
+    {
+      "type":"RecordDeclaration",
+      "loc":{"source":null,"start":{"line":1,"column":0},"end":{"line":4,"column":0}},
+      "range":[0,28],
+      "id":{
+        "type":"Identifier",
+        "loc":{"source":null,"start":{"line":1,"column":7},"end":{"line":1,"column":8}},
+        "range":[7,8],
+        "name":"R",
+        "typeAnnotation":null,
+        "optional":false
+      },
+      "typeParameters":null,
+      "implements":[],
+      "body":{
+        "type":"RecordBody",
+        "loc":{"source":null,"start":{"line":1,"column":9},"end":{"line":4,"column":0}},
+        "range":[9,28],
+        "body":[
+          {
+            "type":"MethodDefinition",
+            "loc":{"source":null,"start":{"line":2,"column":5},"end":{"line":4,"column":0}},
+            "range":[16,28],
+            "key":{
+              "type":"Identifier",
+              "loc":{"source":null,"start":{"line":2,"column":5},"end":{"line":2,"column":6}},
+              "range":[16,17],
+              "name":"",
+              "typeAnnotation":null,
+              "optional":false
+            },
+            "value":{
+              "type":"FunctionExpression",
+              "loc":{"source":null,"start":{"line":2,"column":7},"end":{"line":4,"column":0}},
+              "range":[18,28],
+              "id":null,
+              "params":[
+                {
+                  "type":"Identifier",
+                  "loc":{"source":null,"start":{"line":2,"column":13},"end":{"line":2,"column":14}},
+                  "range":[24,25],
+                  "name":"",
+                  "typeAnnotation":null,
+                  "optional":false
+                }
+              ],
+              "body":{
+                "type":"BlockStatement",
+                "loc":{"source":null,"start":{"line":4,"column":0},"end":{"line":4,"column":0}},
+                "range":[28,28],
+                "body":[]
+              },
+              "async":false,
+              "generator":false,
+              "predicate":null,
+              "expression":false,
+              "returnType":null,
+              "typeParameters":null
+            },
+            "kind":"method",
+            "static":false,
+            "computed":false,
+            "decorators":[]
+          }
+        ]
+      }
+    }
+  ],
+  "comments":[]
+}