[flow][refactor] Remove unused 'class' node_cache

Summary:
Remove unused 'class' node_cache - we never called `set_class` anywhere.
Note that we do set and get the `class_sig` node_cache - this is kept.

Changelog: [internal]

Reviewed By: SamChou19815

Differential Revision: D87485745

fbshipit-source-id: 373e50cd471194af7291e41d55bfa37769020253

Author: gkz

src/typing/node_cache.ml

@@ -32,7 +32,6 @@ type cache = {
     (Type.t * (ALoc.t, ALoc.t * Type.t) Ast.Statement.DeclareComponent.t) ALocMap.t;
   declared_namespaces:
     (Type.t * (ALoc.t, ALoc.t * Type.t) Ast.Statement.DeclareNamespace.t) ALocMap.t;
-  classes: (Type.t * (ALoc.t, ALoc.t * Type.t) Ast.Class.t) ALocMap.t;
   class_sigs:
     ( Type.t
     * Type.t
@@ -71,7 +70,6 @@ let mk_empty () =
       declared_classes = ALocMap.empty;
       declared_components = ALocMap.empty;
       declared_namespaces = ALocMap.empty;
-      classes = ALocMap.empty;
       class_sigs = ALocMap.empty;
       tparams = ALocMap.empty;
       component_sigs = ALocMap.empty;
@@ -116,9 +114,6 @@ let set_declared_class cache loc class_ =
 let set_declared_namespace cache loc ns =
   cache := { !cache with declared_namespaces = ALocMap.add loc ns !cache.declared_namespaces }
 
-let set_class cache loc class_ =
-  cache := { !cache with classes = ALocMap.add loc class_ !cache.classes }
-
 let set_class_sig cache loc class_ =
   cache := { !cache with class_sigs = ALocMap.add loc class_ !cache.class_sigs }
 
@@ -159,8 +154,6 @@ let get_declared_component cache loc = ALocMap.find_opt loc !cache.declared_comp
 
 let get_declared_namespace cache loc = ALocMap.find_opt loc !cache.declared_namespaces
 
-let get_class cache loc = ALocMap.find_opt loc !cache.classes
-
 let get_class_sig cache loc = ALocMap.find_opt loc !cache.class_sigs
 
 let get_tparam cache loc = ALocMap.find_opt loc !cache.tparams

src/typing/node_cache.mli

@@ -52,8 +52,6 @@ val set_declared_component :
 val set_declared_namespace :
   t -> ALoc.t -> Type.t * (ALoc.t, ALoc.t * Type.t) Ast.Statement.DeclareNamespace.t -> unit
 
-val set_class : t -> ALoc.t -> Type.t * (ALoc.t, ALoc.t * Type.t) Ast.Class.t -> unit
-
 val set_class_sig :
   t ->
   ALoc.t ->
@@ -123,8 +121,6 @@ val get_declared_component :
 val get_declared_namespace :
   t -> ALoc.t -> (Type.t * (ALoc.t, ALoc.t * Type.t) Ast.Statement.DeclareNamespace.t) option
 
-val get_class : t -> ALoc.t -> (Type.t * (ALoc.t, ALoc.t * Type.t) Ast.Class.t) option
-
 val get_class_sig :
   t ->
   ALoc.t ->

src/typing/statement.ml

@@ -7381,40 +7381,32 @@ module Make
       )
 
   and mk_class cx class_loc ~name_loc ?tast_class_type reason c =
-    let node_cache = Context.node_cache cx in
-    match Node_cache.get_class node_cache class_loc with
-    | Some x ->
-      Debug_js.Verbose.print_if_verbose_lazy
-        cx
-        (lazy [spf "Class cache hit at %s" (ALoc.debug_to_string (loc_of_reason reason))]);
-      x
-    | None ->
-      let def_reason = repos_reason class_loc reason in
-      let (class_t, _, class_sig, class_ast_f) =
-        mk_class_sig cx ~name_loc ~class_loc ~inst_kind:ClassKind reason c
-      in
+    let def_reason = repos_reason class_loc reason in
+    let (class_t, _, class_sig, class_ast_f) =
+      mk_class_sig cx ~name_loc ~class_loc ~inst_kind:ClassKind reason c
+    in
 
-      let public_property_map =
-        Class_stmt_sig.fields_to_prop_map cx
-        @@ Class_stmt_sig.public_fields_of_signature ~static:false class_sig
-      in
-      let private_property_map =
-        Class_stmt_sig.fields_to_prop_map cx
-        @@ Class_stmt_sig.private_fields_of_signature ~static:false class_sig
-      in
-      Class_stmt_sig.check_signature_compatibility cx def_reason class_sig;
-      Class_stmt_sig.toplevels cx class_sig;
+    let public_property_map =
+      Class_stmt_sig.fields_to_prop_map cx
+      @@ Class_stmt_sig.public_fields_of_signature ~static:false class_sig
+    in
+    let private_property_map =
+      Class_stmt_sig.fields_to_prop_map cx
+      @@ Class_stmt_sig.private_fields_of_signature ~static:false class_sig
+    in
+    Class_stmt_sig.check_signature_compatibility cx def_reason class_sig;
+    Class_stmt_sig.toplevels cx class_sig;
 
-      let class_body = Ast.Class.((snd c.body).Body.body) in
-      Context.add_voidable_check
-        cx
-        {
-          Context.public_property_map;
-          private_property_map;
-          errors = Property_assignment.eval_property_assignment class_body;
-        };
-      let tast_class_type = Base.Option.value tast_class_type ~default:class_t in
-      (class_t, class_ast_f tast_class_type)
+    let class_body = Ast.Class.((snd c.body).Body.body) in
+    Context.add_voidable_check
+      cx
+      {
+        Context.public_property_map;
+        private_property_map;
+        errors = Property_assignment.eval_property_assignment class_body;
+      };
+    let tast_class_type = Base.Option.value tast_class_type ~default:class_t in
+    (class_t, class_ast_f tast_class_type)
 
   (* Process a class definition, returning a (polymorphic) class type. A class
      type is a wrapper around an instance type, which contains types of instance