[flow][records] Update language of cannot reassign binding error for records

Summary:
Update language of cannot reassign binding error for records

Changelog: [internal]

Reviewed By: marcoww6

Differential Revision: D87011454

fbshipit-source-id: c4d04e7daa47436dce44bbed856538a2fb510431

Author: gkz

src/analysis/bindings.ml

@@ -32,6 +32,7 @@ type kind =
   | GeneratorNext
   | Component
   | ComponentParameter
+  | Record
 [@@deriving show]
 
 type 'loc entry = ('loc, 'loc) Ast.Identifier.t * kind

src/analysis/bindings.mli

@@ -32,6 +32,7 @@ type kind =
   | GeneratorNext
   | Component
   | ComponentParameter
+  | Record
 [@@deriving show]
 
 type 'loc t

src/analysis/env_builder/name_resolver.ml

@@ -784,6 +784,16 @@ module Make (Context : C) (FlowAPIUtils : F with type cx = Context.t) :
                binding_kind = Flow_intermediate_error_types.ClassNameBinding;
              }
           )
+      | (Bindings.Record, AssignmentWrite) ->
+        let def_reason = mk_reason (RIdentifier (OrdinaryName name)) def_loc in
+        Some
+          (Error_message.EAssignConstLikeBinding
+             {
+               loc = assignment_loc;
+               definition = def_reason;
+               binding_kind = Flow_intermediate_error_types.RecordNameBinding;
+             }
+          )
       | (Bindings.Function, AssignmentWrite) ->
         let def_reason = mk_reason (RIdentifier (OrdinaryName name)) def_loc in
         Some
@@ -832,7 +842,7 @@ module Make (Context : C) (FlowAPIUtils : F with type cx = Context.t) :
           Error_message.(
             EBindingError (EVarRedeclaration, assignment_loc, OrdinaryName name, def_loc)
           )
-      | ( Bindings.(Const | Let | Class | Function | Component | Import | Type _),
+      | ( Bindings.(Const | Let | Class | Record | Function | Component | Import | Type _),
           ( VarBinding | LetBinding | ClassBinding | ConstBinding | FunctionBinding
           | ComponentBinding )
         )
@@ -1636,7 +1646,7 @@ module Make (Context : C) (FlowAPIUtils : F with type cx = Context.t) :
                 heap_refinements = ref HeapRefinementMap.empty;
                 kind;
               }
-            | Bindings.(Class | Enum) ->
+            | Bindings.(Class | Enum | Record) ->
               let (havoc, providers) = this#providers_of_def_loc loc in
               let write_entries =
                 Base.List.fold
@@ -1999,6 +2009,7 @@ module Make (Context : C) (FlowAPIUtils : F with type cx = Context.t) :
               | Bindings.Const
               | Bindings.Let
               | Bindings.Class
+              | Bindings.Record
               | Bindings.Function
               | Bindings.Component
               | Bindings.Parameter

src/analysis/hoister.ml

@@ -264,7 +264,7 @@ class ['loc] lexical_hoister ~flowmin_compatibility ~enable_enums =
     method! record_declaration _loc (record : ('loc, 'loc) Ast.Statement.RecordDeclaration.t) =
       let open Ast.Statement.RecordDeclaration in
       let { id; _ } = record in
-      this#add_const_binding ~kind:Bindings.Class id;
+      this#add_const_binding ~kind:Bindings.Record id;
       record
   end
 

src/typing/errors/flow_intermediate_error_types.ml

@@ -12,12 +12,14 @@ type assigned_const_like_binding_type =
   | FunctionNameBinding
   | DeclaredFunctionNameBinding
   | ComponentNameBinding
+  | RecordNameBinding
 
 let string_of_assigned_const_like_binding_type = function
   | ClassNameBinding -> "class"
   | FunctionNameBinding -> "function"
   | DeclaredFunctionNameBinding -> "declared function"
   | ComponentNameBinding -> "component"
+  | RecordNameBinding -> "record"
 
 type docblock_error =
   | MultipleFlowAttributes

tests/records/declaration.js

@@ -306,7 +306,7 @@ interface Equatable<T> {
 
   x.a as number; // OK
 
-  R = null; // ERROR: cannot reassign - TODO: records - update error message language
+  R = null; // ERROR: cannot reassign
 }
 
 // Multiple generic parameters

tests/records/records.exp

@@ -162,10 +162,10 @@ References:
 
 Error --------------------------------------------------------------------------------------------- declaration.js:309:3
 
-Cannot reassign class binding `R` [1]. [cannot-reassign]
+Cannot reassign record binding `R` [1]. [cannot-reassign]
 
    declaration.js:309:3
-   309|   R = null; // ERROR: cannot reassign - TODO: records - update error message language
+   309|   R = null; // ERROR: cannot reassign
           ^
 
 References: