Skip to content

[test] Cleanup stack assertions in tests mixing React Server and Client #35316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eps1lon merged 1 commit into from
Dec 7, 2025
Merged

[test] Cleanup stack assertions in tests mixing React Server and Client #35316

eps1lon merged 1 commit into from
Dec 7, 2025
+19 −38

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Dec 7, 2025 •
edited
Loading

Some were using ReactClient.createElement instead of ReactServer.createElement.

Others were including an irrelevant stack frame making it harder to review diffs. I suspect most of the variation was caused by our JSX transform not sourcemapping perfectly.

@meta-cla meta-cla bot added the CLA Signed label Dec 7, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Dec 7, 2025
@eps1lon eps1lon force-pushed the sebbie/12-07-_test_cleanup_stack_assertions_in_tests_mixing_react_server_and_client branch 2 times, most recently from c1b3d92 to 6e390b4 Compare December 7, 2025 11:49
@react-sizebot
Copy link

react-sizebot commented Dec 7, 2025 •
edited
Loading

Comparing: 4174533...d719d8c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.36 kB 608.36 kB = 107.68 kB 107.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 667.47 kB 667.47 kB = 117.57 kB 117.57 kB
facebook-www/ReactDOM-prod.classic.js = 693.67 kB 693.67 kB = 122.07 kB 122.06 kB
facebook-www/ReactDOM-prod.modern.js = 684.10 kB 684.10 kB = 120.45 kB 120.45 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js New file 0.00 kB 189.16 kB New file 0.00 kB 33.08 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js New file 0.00 kB 70.68 kB New file 0.00 kB 13.78 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js New file 0.00 kB 238.40 kB New file 0.00 kB 42.41 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js New file 0.00 kB 118.96 kB New file 0.00 kB 23.48 kB
oss-experimental/react-server-dom-webpack/client.node.unbundled.js New file 0.00 kB 0.27 kB New file 0.00 kB 0.17 kB
oss-experimental/react-server-dom-webpack/server.node.unbundled.js New file 0.00 kB 0.87 kB New file 0.00 kB 0.33 kB
oss-experimental/react-server-dom-webpack/static.node.unbundled.js New file 0.00 kB 0.31 kB New file 0.00 kB 0.19 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js New file 0.00 kB 189.16 kB New file 0.00 kB 33.08 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js New file 0.00 kB 70.68 kB New file 0.00 kB 13.78 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js New file 0.00 kB 236.31 kB New file 0.00 kB 41.95 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js New file 0.00 kB 117.11 kB New file 0.00 kB 23.11 kB
oss-stable-semver/react-server-dom-webpack/client.node.unbundled.js New file 0.00 kB 0.27 kB New file 0.00 kB 0.17 kB
oss-stable-semver/react-server-dom-webpack/server.node.unbundled.js New file 0.00 kB 0.87 kB New file 0.00 kB 0.33 kB
oss-stable-semver/react-server-dom-webpack/static.node.unbundled.js New file 0.00 kB 0.31 kB New file 0.00 kB 0.19 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js New file 0.00 kB 189.16 kB New file 0.00 kB 33.08 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js New file 0.00 kB 70.68 kB New file 0.00 kB 13.78 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js New file 0.00 kB 236.31 kB New file 0.00 kB 41.95 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js New file 0.00 kB 117.11 kB New file 0.00 kB 23.11 kB
oss-stable/react-server-dom-webpack/client.node.unbundled.js New file 0.00 kB 0.27 kB New file 0.00 kB 0.17 kB
oss-stable/react-server-dom-webpack/server.node.unbundled.js New file 0.00 kB 0.87 kB New file 0.00 kB 0.33 kB
oss-stable/react-server-dom-webpack/static.node.unbundled.js New file 0.00 kB 0.31 kB New file 0.00 kB 0.19 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.development.js Deleted 189.15 kB 0.00 kB Deleted 33.07 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.production.js Deleted 70.67 kB 0.00 kB Deleted 13.77 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js Deleted 238.39 kB 0.00 kB Deleted 42.40 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.production.js Deleted 118.95 kB 0.00 kB Deleted 23.48 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/client.js Deleted 0.25 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/esm/react-server-dom-unbundled-node-loader.production.js Deleted 20.07 kB 0.00 kB Deleted 4.93 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/index.js Deleted 0.29 kB 0.00 kB Deleted 0.22 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/server.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/server.node.js Deleted 0.85 kB 0.00 kB Deleted 0.32 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/static.node.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.development.js Deleted 189.15 kB 0.00 kB Deleted 33.07 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.production.js Deleted 70.67 kB 0.00 kB Deleted 13.77 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js Deleted 236.30 kB 0.00 kB Deleted 41.94 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.production.js Deleted 117.10 kB 0.00 kB Deleted 23.10 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/client.js Deleted 0.25 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/esm/react-server-dom-unbundled-node-loader.production.js Deleted 20.07 kB 0.00 kB Deleted 4.93 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/index.js Deleted 0.29 kB 0.00 kB Deleted 0.22 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/server.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/server.node.js Deleted 0.85 kB 0.00 kB Deleted 0.32 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/static.node.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.development.js Deleted 189.15 kB 0.00 kB Deleted 33.07 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.production.js Deleted 70.67 kB 0.00 kB Deleted 13.77 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js Deleted 236.30 kB 0.00 kB Deleted 41.94 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.production.js Deleted 117.10 kB 0.00 kB Deleted 23.10 kB 0.00 kB
oss-stable/react-server-dom-unbundled/client.js Deleted 0.25 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-server-dom-unbundled/esm/react-server-dom-unbundled-node-loader.production.js Deleted 20.07 kB 0.00 kB Deleted 4.93 kB 0.00 kB
oss-stable/react-server-dom-unbundled/index.js Deleted 0.29 kB 0.00 kB Deleted 0.22 kB 0.00 kB
oss-stable/react-server-dom-unbundled/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable/react-server-dom-unbundled/server.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-server-dom-unbundled/server.node.js Deleted 0.85 kB 0.00 kB Deleted 0.32 kB 0.00 kB
oss-stable/react-server-dom-unbundled/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-server-dom-unbundled/static.node.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js New file 0.00 kB 189.16 kB New file 0.00 kB 33.08 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js New file 0.00 kB 70.68 kB New file 0.00 kB 13.78 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js New file 0.00 kB 238.40 kB New file 0.00 kB 42.41 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js New file 0.00 kB 118.96 kB New file 0.00 kB 23.48 kB
oss-experimental/react-server-dom-webpack/client.node.unbundled.js New file 0.00 kB 0.27 kB New file 0.00 kB 0.17 kB
oss-experimental/react-server-dom-webpack/server.node.unbundled.js New file 0.00 kB 0.87 kB New file 0.00 kB 0.33 kB
oss-experimental/react-server-dom-webpack/static.node.unbundled.js New file 0.00 kB 0.31 kB New file 0.00 kB 0.19 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js New file 0.00 kB 189.16 kB New file 0.00 kB 33.08 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js New file 0.00 kB 70.68 kB New file 0.00 kB 13.78 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js New file 0.00 kB 236.31 kB New file 0.00 kB 41.95 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js New file 0.00 kB 117.11 kB New file 0.00 kB 23.11 kB
oss-stable-semver/react-server-dom-webpack/client.node.unbundled.js New file 0.00 kB 0.27 kB New file 0.00 kB 0.17 kB
oss-stable-semver/react-server-dom-webpack/server.node.unbundled.js New file 0.00 kB 0.87 kB New file 0.00 kB 0.33 kB
oss-stable-semver/react-server-dom-webpack/static.node.unbundled.js New file 0.00 kB 0.31 kB New file 0.00 kB 0.19 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js New file 0.00 kB 189.16 kB New file 0.00 kB 33.08 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js New file 0.00 kB 70.68 kB New file 0.00 kB 13.78 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js New file 0.00 kB 236.31 kB New file 0.00 kB 41.95 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js New file 0.00 kB 117.11 kB New file 0.00 kB 23.11 kB
oss-stable/react-server-dom-webpack/client.node.unbundled.js New file 0.00 kB 0.27 kB New file 0.00 kB 0.17 kB
oss-stable/react-server-dom-webpack/server.node.unbundled.js New file 0.00 kB 0.87 kB New file 0.00 kB 0.33 kB
oss-stable/react-server-dom-webpack/static.node.unbundled.js New file 0.00 kB 0.31 kB New file 0.00 kB 0.19 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.development.js Deleted 189.15 kB 0.00 kB Deleted 33.07 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.production.js Deleted 70.67 kB 0.00 kB Deleted 13.77 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js Deleted 238.39 kB 0.00 kB Deleted 42.40 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.production.js Deleted 118.95 kB 0.00 kB Deleted 23.48 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/client.js Deleted 0.25 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/esm/react-server-dom-unbundled-node-loader.production.js Deleted 20.07 kB 0.00 kB Deleted 4.93 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/index.js Deleted 0.29 kB 0.00 kB Deleted 0.22 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/server.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/server.node.js Deleted 0.85 kB 0.00 kB Deleted 0.32 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-server-dom-unbundled/static.node.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.development.js Deleted 189.15 kB 0.00 kB Deleted 33.07 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.production.js Deleted 70.67 kB 0.00 kB Deleted 13.77 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js Deleted 236.30 kB 0.00 kB Deleted 41.94 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.production.js Deleted 117.10 kB 0.00 kB Deleted 23.10 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/client.js Deleted 0.25 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/esm/react-server-dom-unbundled-node-loader.production.js Deleted 20.07 kB 0.00 kB Deleted 4.93 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/index.js Deleted 0.29 kB 0.00 kB Deleted 0.22 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/server.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/server.node.js Deleted 0.85 kB 0.00 kB Deleted 0.32 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-server-dom-unbundled/static.node.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.development.js Deleted 189.15 kB 0.00 kB Deleted 33.07 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-client.node.production.js Deleted 70.67 kB 0.00 kB Deleted 13.77 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js Deleted 236.30 kB 0.00 kB Deleted 41.94 kB 0.00 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.production.js Deleted 117.10 kB 0.00 kB Deleted 23.10 kB 0.00 kB
oss-stable/react-server-dom-unbundled/client.js Deleted 0.25 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-server-dom-unbundled/esm/react-server-dom-unbundled-node-loader.production.js Deleted 20.07 kB 0.00 kB Deleted 4.93 kB 0.00 kB
oss-stable/react-server-dom-unbundled/index.js Deleted 0.29 kB 0.00 kB Deleted 0.22 kB 0.00 kB
oss-stable/react-server-dom-unbundled/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable/react-server-dom-unbundled/server.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-server-dom-unbundled/server.node.js Deleted 0.85 kB 0.00 kB Deleted 0.32 kB 0.00 kB
oss-stable/react-server-dom-unbundled/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-server-dom-unbundled/static.node.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB

Generated by 🚫 dangerJS against d719d8c

@eps1lon eps1lon force-pushed the sebbie/12-07-_test_cleanup_stack_assertions_in_tests_mixing_react_server_and_client branch from 6e390b4 to d719d8c Compare December 7, 2025 11:55
@eps1lon eps1lon marked this pull request as ready for review December 7, 2025 12:00
@eps1lon eps1lon requested a review from unstubbable December 7, 2025 13:11
@eps1lon eps1lon merged commit 380778d into facebook:main Dec 7, 2025
241 checks passed
@eps1lon eps1lon deleted the sebbie/12-07-_test_cleanup_stack_assertions_in_tests_mixing_react_server_and_client branch December 7, 2025 16:45
This was referenced Dec 9, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@unstubbable unstubbable Awaiting requested review from unstubbable

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eps1lon @react-sizebot @sebmarkbage