Update ignition to 2.24.0

[LittleFox94]

Update Ignition from 2.22.0 to 2.24.0

Patches were reordered a bit, e.g. combining the
"mod-add-flatcar-ignition-0.36.2" and "sum-go-mod-tidy" patches and moving "config-v3_6-convert-ignition-2.x-to-3.x" before "vendor-go-mod-vendor" (so that the dependencies added by the former are vendored in the latter).

There was also a bigger change in upstream coreos-ignition, requiring a bit more work in one of the patches (provider-qemu-apply-fw_cfg-patch).

I've mostly worked on this in preparation of contributing an UpCloud OEM package for Flatcar; but think this update is just useful in general.

How to use

Build image, throw ignition configs at it and see if they are applied I guess?

Testing done

Built an image and tested it with the yet-unpublished UpCloud OEM on UpCloud infrastructure; using this ignition config:

{
  "ignition": {
    "version": "3.0.0"
  },
  "passwd": {
    "users": [
      {
        "name": "mgrosch",
        "groups": [
          "sudo"
        ],
        "sshAuthorizedKeys": [
          "ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBC91hG6w4Ha/t3vPGX0cqCwSg3+jpyv/lJqMfbRaKNz5SDYgey/zQ/W/5x07AukIqPrGAOvimNnMAn1K99o2tDM= littlefox@localhost"
        ]
      }
    ]
  }
}

This was applied as expected, verified by logging in via SSH using pubkey authentication.

• Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
• Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.
• CI: http://localhost:8080/job/container/job/packages_all_arches/7050/cldsv/

[LittleFox94]

Guess I should add a changelog entry; will wait for the tests before doing that

[tormath1]

@LittleFox94 wow, thanks a lot! I've kicked-off a CI run on our internal CI. The CI from the GitHub Actions only tests qemu instances. While this change impacts all cloud providers, it's better to test on all supported cloud providers.

[LittleFox94]

@tormath1 thanks a lot :)

The CI link you edited into the description points to localhost tho, copy&paste mistake maybe? ^^`

[tormath1]

@tormath1 thanks a lot :)

The CI link you edited into the description points to localhost tho, copy&paste mistake maybe? ^^`

Aha, no that's "expected" - as said, it's the Flatcar internal CI. It's unfortunately not open but we might revisit this next year. :)

Images are available for download here for testing: https://bincache.flatcar-linux.net/images/amd64/9999.0.100+tormath1-ignition-2-24/

For the test results, everything is green on the various cloud provider.

[tormath1]

LGTM. Thanks a lot for this update, upgrading Ignition is always a bit tricky on the Flatcar side as we still want to maintain some backwards compatibility.

CI is OK, changes are OK. One changelog entry to be added and we're good to ship it.

[LittleFox94]

Alright, nice - thanks for looking at this so quickly, I'll write and push a changelog entry :)

[LittleFox94]

.. okay, didn't look at this before - but if changelog really is just that, that's now done as well ^^

(oh funny, they messed up the date for that version in the changelog ^^)

[tormath1]

.. okay, didn't look at this before - but if changelog really is just that, that's now done as well ^^

(oh funny, they messed up the date for that version in the changelog ^^)

Yes, that's good. It's just a matter of adding this file. For the error in the changelog, feel free to submit a PR to the upstream and we can update this changelog entry right after.

[LittleFox94]

.. okay, didn't look at this before - but if changelog really is just that, that's now done as well ^^
(oh funny, they messed up the date for that version in the changelog ^^)

Yes, that's good. It's just a matter of adding this file. For the error in the changelog, feel free to submit a PR to the upstream and we can update this changelog entry right after.

raised a PR to add a note to that release note entry; as to not invalidate any links to it: coreos/ignition#2171

[LittleFox94]

Okay the upstream changelog entry has been augmented; anything else to do here @tormath1 ? :)

[tormath1]

Okay the upstream changelog entry has been augmented; anything else to do here @tormath1 ? :)

Hey, I was AFK yesterday. Thanks for the upstream update and for this great contribution. Looking forward to see Flatcar UpCloud support 😉

[LittleFox94]

Didn't mean to rush you, sorry ^^'

Thanks for merging and I'll open some more PRs soon, tho they should all be a lot smaller - should I tag you in them?