Fix Crespo issues with modern Pandas versions #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pd.date_range() argument "closed" was deprecated in Pandas 1.4 with "inclusive" as the preferred replacement. See pandas-dev/pandas#40245. The expanding() argument "center" was deprecated in Pandas 1.1 as "non-sensical" with no replacement. See pandas-dev/pandas#20647. As discussed in that issue, I believe the use of center=True is a bug in the Crespo implementation, and removing it is the right thing to do. Both of these deprecated arguments were removed in Pandas 2.0, so this change is needed to make Crespo work with recent Pandas versions. To ensure no breakage because of this change, I'm adding a pandas>=1.4.0 dependency version constraint to ensure the presence of the "inclusive" argument to pd.date_range().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pd.date_range()argumentclosedwas deprecated in Pandas 1.4 withinclusiveas the preferred replacement. See pandas-dev/pandas#40245.The
expanding()argumentcenterwas deprecated in Pandas 1.1 as "non-sensical" with no replacement. See pandas-dev/pandas#20647. As discussed in that issue, I believe the use ofcenter=Trueis a bug in the Crespo implementation, and removing it is the right thing to do.Both of these deprecated arguments were removed in Pandas 2.0, so this change is needed to make Crespo work with recent Pandas versions.
To ensure no breakage because of this change, I'm adding a
pandas>=1.4.0dependency version constraint to ensure the presence of theinclusiveargument topd.date_range().