Skip to content

push-to-pull-request-branch doesn't add a comment at all when there is no activation comment (e.g. schedule trigger) #17529

@dsyme

Description

@dsyme

(Have a fix for this, creating tracking issue here)

When running a workflow using safe output push-to-pull-request-branch running from a schedule dispatch I'm seeing

  1. No activation comment is pushed (that's OK, it's a schedule trigger not a pull request comment trigger)

  2. But then no comment is pushed as part of the actual apply of the safe output

I see this in the log


/usr/bin/git am /tmp/gh-aw/aw-repo-assist-add-mapasyncunorderedparallelthrottled-001ed43df569b4c9.patch
Applying: Add tests for AsyncSeq.mapAsyncUnorderedParallelThrottled
Patch applied successfully
/usr/bin/git push origin repo-assist/add-mapasyncunorderedparallelthrottled-001ed43df569b4c9
To https://github.com/fsprojects/FSharp.Control.AsyncSeq.git
   4028f38..41b061a  repo-assist/add-mapasyncunorderedparallelthrottled-001ed43df569b4c9 -> repo-assist/add-mapasyncunorderedparallelthrottled-001ed43df569b4c9
Changes committed and pushed to branch: repo-assist/add-mapasyncunorderedparallelthrottled-001ed43df569b4c9
/usr/bin/git rev-parse HEAD
41b061a0abc1c574c8ca4344bb69961efee7b45c
No activation comment to update (GH_AW_COMMENT_ID not set)
✓ Message 1 (push_to_pull_request_branch) completed successfully

The "No activation comment to update (GH_AW_COMMENT_ID not set)" seems to indicate that adding a comment was skipped entirely because there was no activation comment

https://github.com/fsprojects/FSharp.Control.AsyncSeq/actions/runs/22260054627/job/64397068179#step:8:209

PR being update is here:

fsprojects/FSharp.Control.AsyncSeq#225

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions