-
Notifications
You must be signed in to change notification settings - Fork 441
feat(lint): poc 2.0 linter gno handle extensions rules #4940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(lint): poc 2.0 linter gno handle extensions rules #4940
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
New Proposal for Linter Extension Rules
I did this first PR #4913 to implement linting warning on avl tree iterate method without limit.
It was a "savage" PoC mixing preprocessing and linting logic.
This PR is an improved proposal with a lintrules interface and where each enabled implementations will run a function on all the nodes of the AST. (The AST traversal is done one time, but each node traversed applied the ruleset enabled)
The question is should i keep going in this way or do i go in the wrong direction ?
My next steps would be:
Small drawing of what i did
cc @moul @aeddi @thehowl