Refine PartialEq binding generation to support C++ types with only operator!=. #59
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erator!=. Rust's PartialEq trait requires an eq method. Previously, Crubit could not generate bindings for C++ types that only overloaded operator!=. This CL addresses this by generating an eq implementation that calls the C++ operator!= thunk and negates its result. Additionally, when a C++ type overloads both operator== and operator!=, it avoids generating a binding for operator!=. Instead, it relies on the default ne implementation provided by Rust's PartialEq trait, which is more idiomatic and avoids a redundant thunk. PiperOrigin-RevId: 831756584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine PartialEq binding generation to support C++ types with only operator!=.
Rust's PartialEq trait requires an eq method. Previously, Crubit could not generate bindings for C++ types that only overloaded operator!=.
This CL addresses this by generating an eq implementation that calls the C++ operator!= thunk and negates its result.
Additionally, when a C++ type overloads both operator== and operator!=, it avoids generating a binding for operator!=. Instead, it relies on the default ne implementation provided by Rust's PartialEq trait, which is more idiomatic and avoids a redundant thunk.