Removing change detection on push on brew and bean, cause images/flow profiles are not loading correctly.

But for this we remove the loading spinner

Author: graphefruit

src/components/bean-information/bean-information.component.ts

@@ -1,5 +1,4 @@
 import {
-  ChangeDetectionStrategy,
   Component,
   ElementRef,
   EventEmitter,
@@ -48,7 +47,6 @@ import { BEAN_FUNCTION_PIPE_ENUM } from '../../enums/beans/beanFunctionPipe';
   selector: 'bean-information',
   templateUrl: './bean-information.component.html',
   styleUrls: ['./bean-information.component.scss'],
-  changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class BeanInformationComponent implements OnInit {
   @Input() public bean: Bean;

src/components/brew-information/brew-information.component.ts

@@ -1,5 +1,4 @@
 import {
-  ChangeDetectionStrategy,
   Component,
   ElementRef,
   EventEmitter,
@@ -49,7 +48,6 @@ declare var window;
   selector: 'brew-information',
   templateUrl: './brew-information.component.html',
   styleUrls: ['./brew-information.component.scss'],
-  changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class BrewInformationComponent implements OnInit {
   @Input() public brew: Brew;

src/components/graph-display-card/graph-display-card.component.html

@@ -1,4 +1,3 @@
-<ion-spinner *ngIf='flowProfileLoading === true' name="dots"></ion-spinner>
 <div #canvaContainer>
   <div  #profileDiv></div>
 </div>

src/components/graph-display-card/graph-display-card.component.ts

@@ -9,7 +9,6 @@ import {
 import { BrewFlow } from '../../classes/brew/brewFlow';
 import { Settings } from '../../classes/settings/settings';
 import BeanconquerorFlowTestDataDummy from '../../assets/BeanconquerorFlowTestDataFourth.json';
-import { TranslateService } from '@ngx-translate/core';
 import { UIHelper } from '../../services/uiHelper';
 import { UIFileHelper } from '../../services/uiFileHelper';
 import { Platform } from '@ionic/angular';
@@ -42,19 +41,16 @@ export class GraphDisplayCardComponent implements OnInit {
 
   public traces: any = {};
 
-  public flowProfileLoading: boolean = true;
-
   @ViewChild('canvaContainer', { read: ElementRef, static: true })
   public canvaContainer: ElementRef;
   @ViewChild('profileDiv', { read: ElementRef, static: true })
   public profileDiv: ElementRef;
   constructor(
-    private readonly translate: TranslateService,
     private readonly uiHelper: UIHelper,
     private readonly uiFileHelper: UIFileHelper,
     private readonly platform: Platform,
     private readonly uiSettingsStorage: UISettingsStorage,
-    private readonly graphHelper: GraphHelperService
+    private readonly graphHelper: GraphHelperService,
   ) {}
 
   public async ngOnInit() {
@@ -65,7 +61,7 @@ export class GraphDisplayCardComponent implements OnInit {
       this.flow_profile_raw = this.uiHelper.cloneData(this.flowProfileData);
     } else if (this.meticulousHistoryData) {
       this.flow_profile_raw = MeticulousDevice.returnBrewFlowForShotData(
-        this.meticulousHistoryData.data
+        this.meticulousHistoryData.data,
       );
     }
     setTimeout(() => {
@@ -114,7 +110,7 @@ export class GraphDisplayCardComponent implements OnInit {
       true,
       chartWidth,
       chartHeight,
-      true
+      true,
     );
 
     return layout;
@@ -129,7 +125,7 @@ export class GraphDisplayCardComponent implements OnInit {
       this.traces = this.graphHelper.fillTraces(
         this.traces,
         graphSettings,
-        true
+        true,
       );
 
       this.graphHelper.fillDataIntoTraces(this.flow_profile_raw, this.traces);
@@ -151,12 +147,10 @@ export class GraphDisplayCardComponent implements OnInit {
         this.profileDiv.nativeElement,
         chartData,
         layout,
-        this.getChartConfig()
+        this.getChartConfig(),
       );
       this.profileDiv.nativeElement.removeAllListeners();
       this.profileDiv.nativeElement.removeAllListeners('plotly_click');
-
-      this.flowProfileLoading = false;
     }, 100);
   }
 
@@ -165,7 +159,7 @@ export class GraphDisplayCardComponent implements OnInit {
       if (this.flowProfilePath !== '') {
         try {
           const jsonParsed = await this.uiFileHelper.readInternalJSONFile(
-            this.flowProfilePath
+            this.flowProfilePath,
           );
           this.flow_profile_raw = jsonParsed;
         } catch (ex) {}