eliminate some unnecessary overrides in JavaTypes

Author: gavinking

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BasicJavaType.java

@@ -34,6 +34,7 @@ default JdbcType getRecommendedJdbcType(JdbcTypeIndicators indicators) {
 
 	@Override
 	default T fromString(CharSequence string) {
-		throw new UnsupportedOperationException();
+		throw new UnsupportedOperationException( "Type " + getTypeName()
+						+ " does not support conversion from String");
 	}
 }

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarDateJavaType.java

@@ -60,7 +60,7 @@ public String toString(Calendar value) {
 	}
 
 	public Calendar fromString(CharSequence string) {
-		Calendar result = new GregorianCalendar();
+		final var result = new GregorianCalendar();
 		result.setTime( JdbcDateJavaType.INSTANCE.fromString( string.toString() ) );
 		return result;
 	}

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarJavaType.java

@@ -69,7 +69,7 @@ public String toString(Calendar value) {
 	}
 
 	public Calendar fromString(CharSequence string) {
-		Calendar result = new GregorianCalendar();
+		final var result = new GregorianCalendar();
 		result.setTime( DateJavaType.INSTANCE.fromString( string.toString() ) );
 		return result;
 	}

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarTimeJavaType.java

@@ -60,7 +60,7 @@ public String toString(Calendar value) {
 	}
 
 	public Calendar fromString(CharSequence string) {
-		Calendar result = new GregorianCalendar();
+		final var result = new GregorianCalendar();
 		result.setTime( JdbcTimeJavaType.INSTANCE.fromString( string.toString() ) );
 		return result;
 	}

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/EmbeddableAggregateJavaType.java

@@ -67,18 +67,6 @@ public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) {
 		);
 	}
 
-	@Override
-	public String toString(T value) {
-		return value.toString();
-	}
-
-	@Override
-	public T fromString(CharSequence string) {
-		throw new UnsupportedOperationException(
-				"Conversion from String strategy not known for this Java type: " + getTypeName()
-		);
-	}
-
 	@Override
 	public <X> X unwrap(T value, Class<X> type, WrapperOptions options) {
 		if ( type.isAssignableFrom( getJavaTypeClass() ) ) {

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/EntityJavaType.java

@@ -11,6 +11,7 @@
 import org.hibernate.type.descriptor.jdbc.JdbcType;
 import org.hibernate.type.descriptor.jdbc.JdbcTypeIndicators;
 
+import static java.lang.System.identityHashCode;
 import static org.hibernate.proxy.HibernateProxy.extractLazyInitializer;
 
 /**
@@ -36,7 +37,7 @@ public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) {
 
 	@Override
 	public int extractHashCode(T value) {
-		return System.identityHashCode( value );
+		return identityHashCode( value );
 	}
 
 	@Override
@@ -57,18 +58,6 @@ public boolean isInstance(Object value) {
 		}
 	}
 
-	@Override
-	public String toString(T value) {
-		return value.toString();
-	}
-
-	@Override
-	public T fromString(CharSequence string) {
-		throw new UnsupportedOperationException(
-				"Conversion from String strategy not known for this Java type: " + getTypeName()
-		);
-	}
-
 	@Override @SuppressWarnings("unchecked") // safe, we do check
 	public <X> X unwrap(T value, Class<X> type, WrapperOptions options) {
 		final var id =

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/JavaTypeBasicAdaptor.java

@@ -37,18 +37,6 @@ public boolean useObjectEqualsHashCode() {
 		return true;
 	}
 
-	@Override
-	public String toString(T value) {
-		return value.toString();
-	}
-
-	@Override
-	public T fromString(CharSequence string) {
-		throw new UnsupportedOperationException(
-				"Conversion from String strategy not known for this Java type: " + getTypeName()
-		);
-	}
-
 	@Override
 	public <X> X unwrap(T value, Class<X> type, WrapperOptions options) {
 		throw new UnsupportedOperationException(

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/MapEntryJavaType.java

@@ -31,11 +31,6 @@ public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) {
 		throw new UnsupportedOperationException( "Unsupported attempt to resolve JDBC type for Map.Entry" );
 	}
 
-	@Override
-	public Map.Entry fromString(CharSequence string) {
-		throw new UnsupportedOperationException( "Unsupported attempt create Map.Entry from String" );
-	}
-
 	@Override
 	public <X> X unwrap(Map.Entry value, Class<X> type, WrapperOptions options) {
 		throw new UnsupportedOperationException( "Unsupported attempt to unwrap Map.Entry value" );

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/UnknownBasicJavaType.java

@@ -61,18 +61,6 @@ public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) {
 		);
 	}
 
-	@Override
-	public String toString(T value) {
-		return value.toString();
-	}
-
-	@Override
-	public T fromString(CharSequence string) {
-		throw new UnsupportedOperationException(
-				"Conversion from String strategy not known for this Java type: " + getTypeName()
-		);
-	}
-
 	@Override
 	public <X> X unwrap(T value, Class<X> type, WrapperOptions options) {
 		if ( type.isAssignableFrom( getJavaTypeClass() ) ) {