fixed the unsoundness of the coerce() method

gavinking · gavinking · commit ab15c87c07af · 2025-12-07T18:58:34.000+01:00
diff --git a/hibernate-core/src/main/java/org/hibernate/cache/internal/DefaultCacheKeysFactory.java b/hibernate-core/src/main/java/org/hibernate/cache/internal/DefaultCacheKeysFactory.java
@@ -67,7 +67,7 @@ public static Object staticCreateEntityKey(Object id, EntityPersister persister,
 
 	private static Object getCoercedId(Object id, SessionFactoryImplementor factory, Type keyType) {
 		return keyType instanceof BasicType<?> basicType
-				? basicType.getJavaTypeDescriptor().coerce( id, factory::getTypeConfiguration )
+				? basicType.getJavaTypeDescriptor().coerce( id )
 				: id;
 	}
 
diff --git a/hibernate-core/src/main/java/org/hibernate/cache/internal/EnabledCaching.java b/hibernate-core/src/main/java/org/hibernate/cache/internal/EnabledCaching.java
@@ -229,7 +229,7 @@ public boolean containsEntity(String entityName, Object identifier) {
 		if ( cacheAccess != null ) {
 			final Object idValue =
 					persister.getIdentifierMapping().getJavaType()
-							.coerce( identifier, sessionFactory::getTypeConfiguration );
+							.coerce( identifier );
 			final Object key = cacheAccess.generateCacheKey(
 					idValue,
 					persister.getRootEntityDescriptor().getEntityPersister(),
diff --git a/hibernate-core/src/main/java/org/hibernate/loader/ast/internal/AbstractMultiIdEntityLoader.java b/hibernate-core/src/main/java/org/hibernate/loader/ast/internal/AbstractMultiIdEntityLoader.java
@@ -161,7 +161,7 @@ private List<T> orderedMultiLoad(
 	}
 
 	private Object coerce(SharedSessionContractImplementor session, JavaType<?> idType, Object id) {
-		return idCoercionEnabled ? idType.coerce( id, session ) : id;
+		return idCoercionEnabled ? idType.coerce( id ) : id;
 	}
 
 	private static LockOptions lockOptions(MultiIdLoadOptions loadOptions) {
diff --git a/hibernate-core/src/main/java/org/hibernate/loader/ast/internal/LoaderHelper.java b/hibernate-core/src/main/java/org/hibernate/loader/ast/internal/LoaderHelper.java
@@ -188,7 +188,7 @@ public static <K> K[] normalizeKeys(
 		}
 		else {
 			for ( int i = 0; i < keys.length; i++ ) {
-				typedArray[i] = keyJavaType.coerce( keys[i], session );
+				typedArray[i] = keyJavaType.cast( keyJavaType.coerce( keys[i] ) );
 			}
 		}
 		return typedArray;
diff --git a/hibernate-core/src/main/java/org/hibernate/loader/internal/IdentifierLoadAccessImpl.java b/hibernate-core/src/main/java/org/hibernate/loader/internal/IdentifierLoadAccessImpl.java
@@ -26,8 +26,6 @@
 import org.hibernate.graph.GraphSemantic;
 import org.hibernate.graph.spi.RootGraphImplementor;
 import org.hibernate.persister.entity.EntityPersister;
-import org.hibernate.type.descriptor.java.JavaType;
-import org.hibernate.type.spi.TypeConfiguration;
 
 import static org.hibernate.proxy.HibernateProxy.extractLazyInitializer;
 
@@ -37,7 +35,7 @@
  * @author Steve Ebersole
  */
 // Hibernate Reactive extends this class: see ReactiveIdentifierLoadAccessImpl
-public class IdentifierLoadAccessImpl<T> implements IdentifierLoadAccess<T>, JavaType.CoercionContext {
+public class IdentifierLoadAccessImpl<T> implements IdentifierLoadAccess<T> {
 	private final LoadAccessContext context;
 	private final EntityPersister entityPersister;
 
@@ -199,7 +197,7 @@ protected Object coerceId(Object id, SessionFactoryImplementor factory) {
 				final var identifierMapping = entityPersister.getIdentifierMapping();
 				return identifierMapping.isVirtual()
 						? id // special case for a class with an @IdClass
-						: identifierMapping.getJavaType().coerce( id, this );
+						: identifierMapping.getJavaType().coerce( id );
 			}
 			catch ( Exception e ) {
 				throw new IllegalArgumentException( "Argument '" + id
@@ -233,11 +231,6 @@ private static boolean isLoadByIdComplianceEnabled(SessionFactoryImplementor fac
 		return factory.getSessionFactoryOptions().getJpaCompliance().isLoadByIdComplianceEnabled();
 	}
 
-	@Override
-	public TypeConfiguration getTypeConfiguration() {
-		return context.getSession().getSessionFactory().getTypeConfiguration();
-	}
-
 	@Override
 	public IdentifierLoadAccess<T> enableFetchProfile(String profileName) {
 		if ( !context.getSession().getFactory().containsFetchProfileDefinition( profileName ) ) {
diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/SimpleNaturalIdMapping.java b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/SimpleNaturalIdMapping.java
@@ -34,18 +34,16 @@
 import org.hibernate.sql.results.graph.DomainResult;
 import org.hibernate.sql.results.graph.DomainResultCreationState;
 import org.hibernate.type.descriptor.java.JavaType;
-import org.hibernate.type.spi.TypeConfiguration;
 
 import static org.hibernate.loader.ast.internal.MultiKeyLoadHelper.supportsSqlArrayType;
 
 /**
  * Single-attribute NaturalIdMapping implementation
  */
 public class SimpleNaturalIdMapping extends AbstractNaturalIdMapping
-		implements JavaType.CoercionContext, BasicValuedMapping {
+		implements BasicValuedMapping {
 	private final SingularAttributeMapping attribute;
 	private final SessionFactoryImplementor sessionFactory;
-	private final TypeConfiguration typeConfiguration;
 
 	public SimpleNaturalIdMapping(
 			SingularAttributeMapping attribute,
@@ -54,7 +52,6 @@ public SimpleNaturalIdMapping(
 		super( declaringType, attribute.getAttributeMetadata().isUpdatable() );
 		this.attribute = attribute;
 		this.sessionFactory = creationProcess.getCreationContext().getSessionFactory();
-		this.typeConfiguration = creationProcess.getCreationContext().getTypeConfiguration();
 	}
 
 	public SingularAttributeMapping getAttribute() {
@@ -143,7 +140,7 @@ public Object normalizeInput(Object incoming) {
 		final Object normalizedValue = normalizedValue( incoming );
 		return isLoadByIdComplianceEnabled()
 				? normalizedValue
-				: getJavaType().coerce( normalizedValue, this );
+				: getJavaType().coerce( normalizedValue );
 	}
 
 	private Object normalizedValue(Object incoming) {
@@ -295,11 +292,6 @@ private Dialect getDialect() {
 		return sessionFactory.getJdbcServices().getDialect();
 	}
 
-	@Override
-	public TypeConfiguration getTypeConfiguration() {
-		return typeConfiguration;
-	}
-
 	@Override
 	public AttributeMapping asAttributeMapping() {
 		return getAttribute();
diff --git a/hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingImpl.java b/hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingImpl.java
@@ -31,7 +31,7 @@
  *
  * @author Steve Ebersole
  */
-public class QueryParameterBindingImpl<T> implements QueryParameterBinding<T>, JavaType.CoercionContext {
+public class QueryParameterBindingImpl<T> implements QueryParameterBinding<T> {
 	private final QueryParameter<T> queryParameter;
 	private final SessionFactoryImplementor sessionFactory;
 
@@ -296,7 +296,6 @@ private void validate(Object value, TemporalType clarifiedTemporalType) {
 		QueryParameterBindingValidator.INSTANCE.validate( getBindType(), value, clarifiedTemporalType, getCriteriaBuilder() );
 	}
 
-	@Override
 	public TypeConfiguration getTypeConfiguration() {
 		return sessionFactory.getTypeConfiguration();
 	}
@@ -337,7 +336,7 @@ private Object coerce(T value, BindableType<? super T> parameterType) {
 		}
 		else {
 			return getCriteriaBuilder().resolveExpressible( parameterType )
-					.getExpressibleJavaType().coerce( value, this );
+					.getExpressibleJavaType().coerce( value );
 		}
 	}
 
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/results/graph/basic/CoercingResultAssembler.java b/hibernate-core/src/main/java/org/hibernate/sql/results/graph/basic/CoercingResultAssembler.java
@@ -30,8 +30,7 @@ public CoercingResultAssembler(
 	@Override
 	public Object extractRawValue(RowProcessingState rowProcessingState) {
 		return assembledJavaType.coerce(
-				super.extractRawValue( rowProcessingState ),
-				rowProcessingState.getSession()
+				super.extractRawValue( rowProcessingState )
 		);
 	}
 }
diff --git a/hibernate-core/src/main/java/org/hibernate/type/AbstractStandardBasicType.java b/hibernate-core/src/main/java/org/hibernate/type/AbstractStandardBasicType.java
@@ -258,7 +258,7 @@ public final String toLoggableString(Object value, SessionFactoryImplementor fac
 			|| !Hibernate.isInitialized( value )
 				? "<uninitialized>"
 				: javaType.extractLoggableRepresentation(
-						javaType.coerce( value, factory::getTypeConfiguration ) );
+						javaType.cast( javaType.coerce( value ) ) );
 	}
 
 	@Override
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ArrayJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ArrayJavaType.java
@@ -128,8 +128,8 @@ public boolean areEqual(Object[] one, Object[] another) {
 					// Horrible hack around the fact that java.sql.Timestamps
 					// can be represented as instances of java.util.Date
 					// (Why do we even allow this? We deprecated java.sql stuff!)
-					elementJavaType.coerce( one[i], null ),
-					elementJavaType.coerce( another[i], null ) )) {
+					elementJavaType.cast( elementJavaType.coerce( one[i] ) ),
+					elementJavaType.cast( elementJavaType.coerce( another[i] ) ) ) ) {
 				return false;
 			}
 		}
@@ -448,7 +448,7 @@ public T[] deepCopy(Object[] value) {
 							// Horrible hack around the fact that java.sql.Timestamps
 							// can be represented as instances of java.util.Date
 							// (Why do we even allow this? We deprecated java.sql stuff!)
-							baseDescriptor.coerce( value[i], null ) );
+							baseDescriptor.cast( baseDescriptor.coerce( value[i] ) ) );
 				}
 				return copy;
 			}
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BigDecimalJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BigDecimalJavaType.java
@@ -130,7 +130,7 @@ public int getDefaultSqlPrecision(Dialect dialect, JdbcType jdbcType) {
 	}
 
 	@Override
-	public <X> BigDecimal coerce(X value, CoercionContext coercionContext) {
+	public BigDecimal coerce(Object value) {
 		if ( value == null ) {
 			return null;
 		}
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BigIntegerJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BigIntegerJavaType.java
@@ -132,7 +132,7 @@ public int getDefaultSqlScale(Dialect dialect, JdbcType jdbcType) {
 	}
 
 	@Override
-	public <X> BigInteger coerce(X value, CoercionContext coercionContext) {
+	public BigInteger coerce(Object value) {
 		if ( value == null ) {
 			return null;
 		}
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteJavaType.java
@@ -136,7 +136,7 @@ public int getDefaultSqlScale(Dialect dialect, JdbcType jdbcType) {
 	}
 
 	@Override
-	public <X> Byte coerce(X value, CoercionContext coercionContext) {
+	public Byte coerce(Object value) {
 		if ( value == null ) {
 			return null;
 		}
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DoubleJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DoubleJavaType.java
@@ -164,7 +164,7 @@ public int getDefaultSqlPrecision(Dialect dialect, JdbcType jdbcType) {
 	}
 
 	@Override
-	public <X> Double coerce(X value, CoercionContext coercionContext) {
+	public Double coerce(Object value) {
 		if ( value == null ) {
 			return null;
 		}
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/FloatJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/FloatJavaType.java
@@ -162,7 +162,7 @@ public int getDefaultSqlPrecision(Dialect dialect, JdbcType jdbcType) {
 	}
 
 	@Override
-	public <X> Float coerce(X value, CoercionContext coercionContext) {
+	public Float coerce(Object value) {
 		if ( value == null ) {
 			return null;
 		}
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/IntegerJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/IntegerJavaType.java
@@ -152,7 +152,7 @@ public int getDefaultSqlScale(Dialect dialect, JdbcType jdbcType) {
 	}
 
 	@Override
-	public Integer coerce(Object value, CoercionContext coercionContext) {
+	public Integer coerce(Object value) {
 		if ( value == null ) {
 			return null;
 		}
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JavaType.java
@@ -315,32 +315,22 @@ default boolean isWider(JavaType<?> javaType) {
 	}
 
 	@FunctionalInterface
+	@Deprecated(forRemoval = true, since = "7.2")
 	interface CoercionContext {
 		TypeConfiguration getTypeConfiguration();
 	}
 
 	/**
 	 * Coerce the given value to this type, if possible.
-	 * The default implementation defined her simply
-	 * performs an unchecked cast. Subclasses may override
-	 * to perform meaningful coercion.
-	 *
-	 * @apiNote This operation is currently unsound. It
-	 * should throw {@link CoercionException} when coercion
-	 * fails, or its return value should be changed to
-	 * {@link Object}. However, both of those changes had
-	 * too much impact for now.
 	 *
 	 * @param value The value to coerce
-	 * @param coercionContext The coercion context
 	 * @return The coerced value, or the given value
 	 *         if no coercion was possible
-	 * @param <X> The type of the value
+	 * @throws CoercionException if coercion fails
 	 */
 	@Incubating
-	default <X> T coerce(X value, CoercionContext coercionContext) {
-		//noinspection unchecked
-		return (T) value;
+	default Object coerce(Object value) {
+		return value;
 	}
 
 	/**
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcDateJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcDateJavaType.java
@@ -115,45 +115,44 @@ public int extractHashCode(Date value) {
 	}
 
 	@Override
-	public Date coerce(Object value, CoercionContext coercionContext) {
+	public Date coerce(Object value) {
 		return wrap( value, null );
 	}
 
-	@SuppressWarnings({"unchecked", "rawtypes"})
 	@Override
-	public Object unwrap(Date value, Class type, WrapperOptions options) {
+	public <X> X unwrap(Date value, Class<X> type, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
 
 		if ( LocalDate.class.isAssignableFrom( type ) ) {
-			return unwrapLocalDate( value );
+			return type.cast( unwrapLocalDate( value ) );
 		}
 
 		if ( java.sql.Date.class.isAssignableFrom( type ) ) {
-			return unwrapSqlDate( value );
+			return type.cast( unwrapSqlDate( value ) );
 		}
 
 		if ( java.util.Date.class.isAssignableFrom( type ) ) {
-			return value;
+			return type.cast( value );
 		}
 
 		if ( Long.class.isAssignableFrom( type ) ) {
-			return unwrapDateEpoch( value );
+			return type.cast( unwrapDateEpoch( value ) );
 		}
 
 		if ( String.class.isAssignableFrom( type ) ) {
-			return toString( value );
+			return type.cast( toString( value ) );
 		}
 
 		if ( Calendar.class.isAssignableFrom( type ) ) {
 			final var gregorianCalendar = new GregorianCalendar();
 			gregorianCalendar.setTimeInMillis( unwrapDateEpoch( value ) );
-			return gregorianCalendar;
+			return type.cast( gregorianCalendar );
 		}
 
 		if ( java.sql.Timestamp.class.isAssignableFrom( type ) ) {
-			return new java.sql.Timestamp( unwrapDateEpoch( value ) );
+			return type.cast( new java.sql.Timestamp( unwrapDateEpoch( value ) ) );
 		}
 
 		if ( java.sql.Time.class.isAssignableFrom( type ) ) {
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimeJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimeJavaType.java
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampJavaType.java
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LongJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LongJavaType.java
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/PrimitiveByteArrayJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/PrimitiveByteArrayJavaType.java
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/PrimitiveCharacterArrayJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/PrimitiveCharacterArrayJavaType.java
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ShortJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ShortJavaType.java
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/StringJavaType.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/StringJavaType.java
diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/spi/BasicJdbcLiteralFormatter.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/spi/BasicJdbcLiteralFormatter.java
diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/mapping/type/java/CoercionTests.java b/hibernate-core/src/test/java/org/hibernate/orm/test/mapping/type/java/CoercionTests.java

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public static Object staticCreateEntityKey(Object id, EntityPersister persister,`
`67`	`67`
`68`	`68`	`private static Object getCoercedId(Object id, SessionFactoryImplementor factory, Type keyType) {`
`69`	`69`	`return keyType instanceof BasicType<?> basicType`
`70`		`- ? basicType.getJavaTypeDescriptor().coerce( id, factory::getTypeConfiguration )`
	`70`	`+ ? basicType.getJavaTypeDescriptor().coerce( id )`
`71`	`71`	`: id;`
`72`	`72`	`}`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ private List<T> orderedMultiLoad(`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`private Object coerce(SharedSessionContractImplementor session, JavaType<?> idType, Object id) {`
`164`		`- return idCoercionEnabled ? idType.coerce( id, session ) : id;`
	`164`	`+ return idCoercionEnabled ? idType.coerce( id ) : id;`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`private static LockOptions lockOptions(MultiIdLoadOptions loadOptions) {`
Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ public static <K> K[] normalizeKeys(`
`188`	`188`	`}`
`189`	`189`	`else {`
`190`	`190`	`for ( int i = 0; i < keys.length; i++ ) {`
`191`		`- typedArray[i] = keyJavaType.coerce( keys[i], session );`
	`191`	`+ typedArray[i] = keyJavaType.cast( keyJavaType.coerce( keys[i] ) );`
`192`	`192`	`}`
`193`	`193`	`}`
`194`	`194`	`return typedArray;`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`*`
`32`	`32`	`* @author Steve Ebersole`
`33`	`33`	`*/`
`34`		`-public class QueryParameterBindingImpl<T> implements QueryParameterBinding<T>, JavaType.CoercionContext {`
	`34`	`+public class QueryParameterBindingImpl<T> implements QueryParameterBinding<T> {`
`35`	`35`	`private final QueryParameter<T> queryParameter;`
`36`	`36`	`private final SessionFactoryImplementor sessionFactory;`
`37`	`37`
`@@ -296,7 +296,6 @@ private void validate(Object value, TemporalType clarifiedTemporalType) {`
`296`	`296`	`QueryParameterBindingValidator.INSTANCE.validate( getBindType(), value, clarifiedTemporalType, getCriteriaBuilder() );`
`297`	`297`	`}`
`298`	`298`
`299`		`- @Override`
`300`	`299`	`public TypeConfiguration getTypeConfiguration() {`
`301`	`300`	`return sessionFactory.getTypeConfiguration();`
`302`	`301`	`}`
`@@ -337,7 +336,7 @@ private Object coerce(T value, BindableType<? super T> parameterType) {`
`337`	`336`	`}`
`338`	`337`	`else {`
`339`	`338`	`return getCriteriaBuilder().resolveExpressible( parameterType )`
`340`		`- .getExpressibleJavaType().coerce( value, this );`
	`339`	`+ .getExpressibleJavaType().coerce( value );`
`341`	`340`	`}`
`342`	`341`	`}`
`343`	`342`
Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,7 @@ public CoercingResultAssembler(`
`30`	`30`	`@Override`
`31`	`31`	`public Object extractRawValue(RowProcessingState rowProcessingState) {`
`32`	`32`	`return assembledJavaType.coerce(`
`33`		`- super.extractRawValue( rowProcessingState ),`
`34`		`- rowProcessingState.getSession()`
	`33`	`+ super.extractRawValue( rowProcessingState )`
`35`	`34`	`);`
`36`	`35`	`}`
`37`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ public final String toLoggableString(Object value, SessionFactoryImplementor fac`
`258`	`258`	`\|\| !Hibernate.isInitialized( value )`
`259`	`259`	`? "<uninitialized>"`
`260`	`260`	`: javaType.extractLoggableRepresentation(`
`261`		`- javaType.coerce( value, factory::getTypeConfiguration ) );`
	`261`	`+ javaType.cast( javaType.coerce( value ) ) );`
`262`	`262`	`}`
`263`	`263`
`264`	`264`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -128,8 +128,8 @@ public boolean areEqual(Object[] one, Object[] another) {`
`128`	`128`	`// Horrible hack around the fact that java.sql.Timestamps`
`129`	`129`	`// can be represented as instances of java.util.Date`
`130`	`130`	`// (Why do we even allow this? We deprecated java.sql stuff!)`
`131`		`- elementJavaType.coerce( one[i], null ),`
`132`		`- elementJavaType.coerce( another[i], null ) )) {`
	`131`	`+ elementJavaType.cast( elementJavaType.coerce( one[i] ) ),`
	`132`	`+ elementJavaType.cast( elementJavaType.coerce( another[i] ) ) ) ) {`
`133`	`133`	`return false;`
`134`	`134`	`}`
`135`	`135`	`}`
`@@ -448,7 +448,7 @@ public T[] deepCopy(Object[] value) {`
`448`	`448`	`// Horrible hack around the fact that java.sql.Timestamps`
`449`	`449`	`// can be represented as instances of java.util.Date`
`450`	`450`	`// (Why do we even allow this? We deprecated java.sql stuff!)`
`451`		`- baseDescriptor.coerce( value[i], null ) );`
	`451`	`+ baseDescriptor.cast( baseDescriptor.coerce( value[i] ) ) );`
`452`	`452`	`}`
`453`	`453`	`return copy;`
`454`	`454`	`}`