auto-create secret from password in connection config #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secret manager PR changed Source::Postgres to use credential refs
instead of inline passwords. This broke the API for clients sending
the old format with a "password" field - it was silently ignored and
discovery failed with "no credential configured".
Now the connection handler detects password fields, auto-creates a
secret named "conn-{name}-password", and replaces it with a SecretRef.
zfarrell
force-pushed
the
fix-password-to-secret-conversion
branch
from
d2f0cc8 to
250ec79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secret manager PR changed Source::Postgres to use credential refs instead of inline passwords. This broke the API for clients sending the old format with a "password" field - it was silently ignored and discovery failed with "no credential configured".
Now the connection handler detects password fields, auto-creates a secret named "conn-{name}-password", and replaces it with a SecretRef.