fix: Allow directory-based ignores for files matches

Author: nzakas

src/config-array.js

@@ -204,7 +204,16 @@ function shouldIgnorePath(ignores, filePath, relativeFilePath) {
 
 			// don't check negated patterns because we're not ignored yet
 			if (!matcher.startsWith('!')) {
-				return doMatch(relativeFilePath, matcher);
+
+				/*
+				 * In order to allow patterns such as "ignore/" to work
+				 * to ignore complete directories, we need to append "**"
+				 * at the end of any pattern that ends with a slash.
+				 * See https://github.com/eslint/eslint/issues/17213
+				 */
+				return matcher.endsWith('/')
+					? doMatch(relativeFilePath, `${matcher}**`)
+					: doMatch(relativeFilePath, matcher);
 			}
 
 			// otherwise we're still not ignored

tests/config-array.test.js

@@ -1252,6 +1252,39 @@ describe('ConfigArray', () => {
 				});				
 			});
 
+			// https://github.com/eslint/eslint/issues/17213
+			describe('ignore entire directory', () => {
+
+				it('should return true when a subdirectory is ignored with double stars', () => {
+					configs = new ConfigArray([
+						{
+							files: ['**/*.js'],
+							ignores: ['ignored/**'],
+						}
+					], { basePath });
+
+					configs.normalizeSync();
+					const filename = path.resolve(basePath, 'ignored/foo.js');
+
+					expect(configs.isFileIgnored(filename)).to.be.true;
+				});
+
+				it('should return true when a subdirectory is ignored with trailing slash', () => {
+					configs = new ConfigArray([
+						{
+							files: ['**/*.js'],
+							ignores: ['ignored/'],
+						}
+					], { basePath });
+
+					configs.normalizeSync();
+					const filename = path.resolve(basePath, 'ignored/foo.js');
+
+					expect(configs.isFileIgnored(filename)).to.be.true;
+				});
+
+			});
+
 		});
 
 		describe('isDirectoryIgnored()', () => {