Skip to content

Soroban storage types conflict with named return parameters in open zeppelin. #1817

@GeorgiosDelkos

Description

@GeorgiosDelkos

Describe the bug
Version 0.3.4 added support for Soroban storage types: persistent, temporary, instance.
Openzeppelin contains a contract implementation that has a function with a return parameter named instance.
Due to the newly added Soroban storage types this can no longer be parsed.

To Reproduce
Steps to reproduce the behavior:

  1. Ethereum
  2. https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/proxy/Clones.sol#L28
  3. 0.3.4 and up
  4. Parsing error
  5. No parsing error

Expected behaviour
The file should parse correctly without an error.
Consider adding these behind a feature gate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions