rename functions to make more sense

Author: ilijamt

internal/token/scope.go

@@ -145,7 +145,7 @@ func (i Scope) Value() string {
 	return i.String()
 }
 
-func ScopeParse(value string) (Scope, error) {
+func ParseScope(value string) (Scope, error) {
 	if slices.Contains(ValidGroupTokenScopes, value) ||
 		slices.Contains(ValidPipelineProjectTokenScopes, value) ||
 		slices.Contains(ValidGroupDeployTokenScopes, value) ||

internal/token/scope_test.go

@@ -79,7 +79,7 @@ func TestTokenScope(t *testing.T) {
 
 	for _, test := range tests {
 		t.Logf("assert parse(%s) = %s (err: %v)", test.input, test.expected, test.err)
-		val, err := token.ScopeParse(test.input)
+		val, err := token.ParseScope(test.input)
 		assert.EqualValues(t, test.expected, val)
 		assert.EqualValues(t, test.expected.Value(), test.expected.String())
 		if test.err {

internal/token/type.go

@@ -43,7 +43,7 @@ func (i Type) Value() string {
 	return i.String()
 }
 
-func TypeParse(value string) (Type, error) {
+func ParseType(value string) (Type, error) {
 	if slices.Contains(ValidTokenTypes, value) {
 		return Type(value), nil
 	}

internal/token/type_test.go

@@ -63,7 +63,7 @@ func TestTokenType(t *testing.T) {
 
 	for _, test := range tests {
 		t.Logf("assert parse(%s) = %s (err: %v)", test.input, test.expected, test.err)
-		val, err := token.TypeParse(test.input)
+		val, err := token.ParseType(test.input)
 		assert.EqualValues(t, test.expected, val)
 		assert.EqualValues(t, test.expected.Value(), test.expected.String())
 		if test.err {

path_role.go

@@ -220,7 +220,7 @@ func (b *Backend) pathRolesWrite(ctx context.Context, req *logical.Request, data
 		return logical.ErrorResponse(errs.ErrBackendNotConfigured.Error()), nil
 	}
 
-	tokenType, _ = token.TypeParse(data.Get("token_type").(string))
+	tokenType, _ = token.ParseType(data.Get("token_type").(string))
 	accessLevel, _ = AccessLevelParse(data.Get("access_level").(string))
 
 	var role = EntryRole{

secret_access_tokens.go

@@ -84,7 +84,7 @@ func (b *Backend) secretAccessTokenRevoke(ctx context.Context, req *logical.Requ
 	var parentId = req.Secret.InternalData["parent_id"].(string)
 	var tokenType token.Type
 	var tokenTypeValue = req.Secret.InternalData["token_type"].(string)
-	tokenType, _ = token.TypeParse(tokenTypeValue)
+	tokenType, _ = token.ParseType(tokenTypeValue)
 
 	if vaultRevokesToken {
 		var client Client