Skip to content

Commit 2e1c09c

Browse files
committed
fix: added a check if backend is nil in the event handler
1 parent 9c732ad commit 2e1c09c

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

internal/event/event.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,16 @@ import (
88
"github.com/hashicorp/vault/sdk/framework"
99
"github.com/hashicorp/vault/sdk/logical"
1010
"google.golang.org/protobuf/types/known/structpb"
11+
12+
"github.com/ilijamt/vault-plugin-secrets-gitlab/internal/errs"
1113
)
1214

1315
func Event(ctx context.Context, b *framework.Backend, prefix, eventType string, metadata map[string]string) error {
1416
var err error
1517
var ev *logical.EventData
18+
if b == nil {
19+
return fmt.Errorf("%w: backend", errs.ErrNilValue)
20+
}
1621
if ev, err = logical.NewEvent(); err == nil {
1722
var metadataBytes []byte
1823
metadataBytes, _ = json.Marshal(metadata)

internal/event/event_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99
"github.com/hashicorp/vault/sdk/logical"
1010
"github.com/stretchr/testify/require"
1111

12+
"github.com/ilijamt/vault-plugin-secrets-gitlab/internal/errs"
1213
"github.com/ilijamt/vault-plugin-secrets-gitlab/internal/event"
1314
)
1415

@@ -33,6 +34,18 @@ func (m *mockEventsSender) SendEvent(ctx context.Context, eventType logical.Even
3334
}
3435

3536
func TestEvent(t *testing.T) {
37+
t.Run("nil backend", func(t *testing.T) {
38+
require.ErrorIs(t,
39+
event.Event(
40+
t.Context(),
41+
nil,
42+
"test", "test",
43+
map[string]string{"test": "test"},
44+
),
45+
errs.ErrNilValue,
46+
)
47+
})
48+
3649
t.Run("no sender specified", func(t *testing.T) {
3750
b := &framework.Backend{}
3851
require.NoError(t, b.Setup(t.Context(), &logical.BackendConfig{}))

0 commit comments

Comments
 (0)