refactor: change the function name to remove Gitlab from the function

Author: ilijamt

backend.go

@@ -181,7 +181,7 @@ func (b *Backend) getClient(ctx context.Context, s logical.Storage, name string)
 
 	var httpClient *http.Client
 	httpClient, _ = HttpClientFromContext(ctx)
-	if client, _ = GitlabClientFromContext(ctx); client == nil {
+	if client, _ = ClientFromContext(ctx); client == nil {
 		if client, err = NewGitlabClient(config, httpClient, b.Logger()); err == nil {
 			b.SetClient(client, name)
 		}

defs.go

@@ -55,11 +55,11 @@ func HttpClientFromContext(ctx context.Context) (*http.Client, bool) {
 	return u, ok
 }
 
-func GitlabClientNewContext(ctx context.Context, client Client) context.Context {
+func ClientNewContext(ctx context.Context, client Client) context.Context {
 	return context.WithValue(ctx, ctxKeyGitlabClient, client)
 }
 
-func GitlabClientFromContext(ctx context.Context) (Client, bool) {
+func ClientFromContext(ctx context.Context) (Client, bool) {
 	u, ok := ctx.Value(ctxKeyGitlabClient).(Client)
 	if !ok {
 		u = nil

defs_test.go

@@ -11,7 +11,7 @@ import (
 )
 
 func TestEmptyGitlabClientFromContext(t *testing.T) {
-	c, ok := gitlab.GitlabClientFromContext(t.Context())
+	c, ok := gitlab.ClientFromContext(t.Context())
 	require.False(t, ok)
 	require.Nil(t, c)
 }

path_config.go

@@ -156,7 +156,7 @@ func (b *Backend) updateConfigClientInfo(ctx context.Context, config *EntryConfi
 	var httpClient *http.Client
 	var client Client
 	httpClient, _ = HttpClientFromContext(ctx)
-	if client, _ = GitlabClientFromContext(ctx); client == nil {
+	if client, _ = ClientFromContext(ctx); client == nil {
 		if client, err = NewGitlabClient(config, httpClient, b.Logger()); err == nil {
 			b.SetClient(client, config.Name)
 		} else {

path_config_token_autorotate_test.go

@@ -157,7 +157,7 @@ func TestPathConfig_AutoRotateToken(t *testing.T) {
 	t.Run("no error when auto rotate is disabled and config is set", func(t *testing.T) {
 		var client = newInMemoryClient(true)
 		ctx, url := getCtxGitlabClientWithUrl(t, "unit")
-		ctx = gitlab.GitlabClientNewContext(ctx, client)
+		ctx = gitlab.ClientNewContext(ctx, client)
 		b, l, err := getBackendWithConfig(ctx, map[string]any{
 			"token":    "glpat-secret-token",
 			"base_url": url,
@@ -173,7 +173,7 @@ func TestPathConfig_AutoRotateToken(t *testing.T) {
 	t.Run("call auto rotate the main token and rotate the token", func(t *testing.T) {
 		var client = newInMemoryClient(true)
 		ctx, url := getCtxGitlabClientWithUrl(t, "unit")
-		ctx = gitlab.GitlabClientNewContext(ctx, newInMemoryClient(true))
+		ctx = gitlab.ClientNewContext(ctx, newInMemoryClient(true))
 		b, l, events, err := getBackendWithEventsAndConfig(ctx, map[string]any{
 			"token":              "token",
 			"base_url":           url,
@@ -224,7 +224,7 @@ func TestPathConfig_AutoRotateToken(t *testing.T) {
 	t.Run("call auto rotate the main token but the token is still valid", func(t *testing.T) {
 		var client = newInMemoryClient(true)
 		ctx, url := getCtxGitlabClientWithUrl(t, "unit")
-		ctx = gitlab.GitlabClientNewContext(ctx, newInMemoryClient(true))
+		ctx = gitlab.ClientNewContext(ctx, newInMemoryClient(true))
 		b, l, err := getBackendWithConfig(ctx, map[string]any{
 			"token":              "token",
 			"base_url":           url,

path_token_role_test.go

@@ -39,7 +39,7 @@ func TestPathTokenRoles(t *testing.T) {
 		t.Logf("token creation, token type: %s, level: %s, gitlab revokes token: %t", tokenType, level, gitlabRevokesToken)
 		ctx := getCtxGitlabClient(t, "unit")
 		client := newInMemoryClient(true)
-		ctx = gitlab.GitlabClientNewContext(ctx, client)
+		ctx = gitlab.ClientNewContext(ctx, client)
 		var b, l, events, err = getBackendWithEvents(ctx)
 		require.NoError(t, err)
 		require.NoError(t, writeBackendConfig(ctx, b, l, defaultConfig))