Provide role scopes as csv to align with config (#246)

* Provide role scopes as csv to align with config

Config already provides its scopes as csv.

Use-case:

I want to set `allowed_parameters` in the policy for `scopes`. However, this is only string based. When using this with terraform and supplying the scopes string based, there will be a constant state drift as the response is different (an array vs a string).

* add missing strings import

---------

Co-authored-by: Ilija Matoski <[email protected]>

Author: danilobuerger

entry_role.go

@@ -3,6 +3,7 @@ package gitlab
 import (
 	"context"
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/hashicorp/vault/sdk/logical"
@@ -35,7 +36,7 @@ func (e EntryRole) LogicalResponseData() map[string]any {
 		"role_name":            e.RoleName,
 		"path":                 e.Path,
 		"name":                 e.Name,
-		"scopes":               e.Scopes,
+		"scopes":               strings.Join(e.Scopes, ", "),
 		"access_level":         e.AccessLevel.String(),
 		"ttl":                  int64(e.TTL / time.Second),
 		"token_type":           e.TokenType.String(),
@@ -54,5 +55,4 @@ func getRole(ctx context.Context, name string, s logical.Storage) (role *EntryRo
 		_ = entry.DecodeJSON(role)
 	}
 	return role, err
-
 }

path_role_test.go

@@ -6,6 +6,7 @@ import (
 	"cmp"
 	"fmt"
 	"os"
+	"strings"
 	"testing"
 	"time"
 
@@ -325,9 +326,9 @@ func TestPathRoles(t *testing.T) {
 					"path":       "user",
 					"name":       "Example user personal token",
 					"token_type": token.TypePersonal.String(),
-					"scopes": []string{
+					"scopes": strings.Join([]string{
 						"invalid_scope",
-					},
+					}, ", "),
 				},
 			})
 			require.Error(t, err)
@@ -423,10 +424,10 @@ func TestPathRoles(t *testing.T) {
 			"token_type":           token.TypePersonal.String(),
 			"ttl":                  int64((5 * 24 * time.Hour).Seconds()),
 			"gitlab_revokes_token": false,
-			"scopes": []string{
+			"scopes": strings.Join([]string{
 				token.ScopeApi.String(),
 				token.ScopeReadRegistry.String(),
-			},
+			}, ", "),
 		}
 
 		// create a role