chore: fix ST1017: don't use Yoda conditions (staticcheck)

ilijamt · ilijamt · commit d751c187a879 · 2025-04-18T08:00:31.000+02:00
diff --git a/gitlab_client.go b/gitlab_client.go
@@ -574,11 +574,11 @@ func (gc *gitlabClient) Valid(ctx context.Context) bool {
 var _ Client = new(gitlabClient)
 
 func newGitlabClient(config *EntryConfig, httpClient *http.Client) (gc *g.Client, err error) {
-	if "" == strings.TrimSpace(config.BaseURL) {
+	if strings.TrimSpace(config.BaseURL) == "" {
 		err = errors.Join(err, fmt.Errorf("gitlab base url: %w", ErrInvalidValue))
 	}
 
-	if "" == strings.TrimSpace(config.Token) {
+	if strings.TrimSpace(config.Token) == "" {
 		err = errors.Join(err, fmt.Errorf("gitlab token: %w", ErrInvalidValue))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -574,11 +574,11 @@ func (gc *gitlabClient) Valid(ctx context.Context) bool {`
`574`	`574`	`var _ Client = new(gitlabClient)`
`575`	`575`
`576`	`576`	`func newGitlabClient(config EntryConfig, httpClient http.Client) (gc *g.Client, err error) {`
`577`		`- if "" == strings.TrimSpace(config.BaseURL) {`
	`577`	`+ if strings.TrimSpace(config.BaseURL) == "" {`
`578`	`578`	`err = errors.Join(err, fmt.Errorf("gitlab base url: %w", ErrInvalidValue))`
`579`	`579`	`}`
`580`	`580`
`581`		`- if "" == strings.TrimSpace(config.Token) {`
	`581`	`+ if strings.TrimSpace(config.Token) == "" {`
`582`	`582`	`err = errors.Join(err, fmt.Errorf("gitlab token: %w", ErrInvalidValue))`
`583`	`583`	`}`
`584`	`584`