Skip to content

Commit cf902d1

Browse files
seqizzTheFRedFox
andcommitted
Apply suggestions from code review
Co-authored-by: Frederik Bauer <[email protected]>
1 parent 4546aa7 commit cf902d1

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/check_plugin_vulnerability.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
44
This scripts checks the Jenkins Plugins for security issues
55
6-
Copyright (c) 2021 InnoGames GmbH
6+
Copyright (c) 2022 InnoGames GmbH
77
"""
88
# Permission is hereby granted, free of charge, to any person obtaining a copy
99
# of this software and associated documentation files (the "Software"), to deal
@@ -29,17 +29,19 @@
2929
from sys import exit
3030

3131
SCRIPT = """
32-
import jenkins.security.*
32+
import jenkins.security.UpdateSiteWarningsConfiguration
33+
import jenkins.security.ExtensionList
34+
import groovy.json.JsonBuilder
3335
ExtensionList<UpdateSiteWarningsConfiguration> configurations = ExtensionList.lookup(UpdateSiteWarningsConfiguration.class);
3436
UpdateSiteWarningsConfiguration configuration = configurations.get(0);
35-
problematic_plugins = []
36-
current_warnings = configuration.getApplicableWarnings()
37+
def problematic_plugins = []
38+
def current_warnings = configuration.getApplicableWarnings()
3739
current_warnings.each {
3840
if (it.type.name() == 'PLUGIN') {
3941
problematic_plugins.add(it.component)
4042
}
4143
}
42-
print(new groovy.json.JsonBuilder(problematic_plugins.unique()))
44+
print(new JsonBuilder(problematic_plugins.unique()))
4345
""" # NOQA E501 Don't wrap because of groovy code
4446

4547
IGNORE_FILE = '/etc/nagios-plugins/check_plugin_vulnerability_ignore'

0 commit comments

Comments
 (0)