Merge pull request #221 from isucon/bench/hotfix-player-validate-index-2

ToshihitoKon · web-flow · commit 96125c95cb90 · 2022-07-23T15:15:19.000+09:00
[bench] hotfix ValidateScenarioのindexミスを修正
diff --git a/bench/scenario_validation.go b/bench/scenario_validation.go
@@ -439,7 +439,7 @@ func allAPISuccessCheck(ctx context.Context, sc *Scenario, step *isucandar.Bench
 					return fmt.Errorf("参加した大会数が違います (want: %d, got: %d)", 1, len(r.Data.Scores))
 				}
 				if competitionTitle != r.Data.Scores[0].CompetitionTitle {
-					return fmt.Errorf("参加した大会IDが違います (want: %s, got: %s)", competitionTitle, r.Data.Scores[checkPlayerIndex].CompetitionTitle)
+					return fmt.Errorf("参加した大会IDが違います (want: %s, got: %s)", competitionTitle, r.Data.Scores[0].CompetitionTitle)
 				}
 				if int64(100+checkPlayerIndex) != r.Data.Scores[0].Score {
 					return fmt.Errorf("スコアが違います (want: %d, got: %d)", 100+checkPlayerIndex, r.Data.Scores[0].Score)

Original file line number	Diff line number	Diff line change
`@@ -439,7 +439,7 @@ func allAPISuccessCheck(ctx context.Context, sc Scenario, step isucandar.Bench`
`439`	`439`	`return fmt.Errorf("参加した大会数が違います (want: %d, got: %d)", 1, len(r.Data.Scores))`
`440`	`440`	`}`
`441`	`441`	`if competitionTitle != r.Data.Scores[0].CompetitionTitle {`
`442`		`- return fmt.Errorf("参加した大会IDが違います (want: %s, got: %s)", competitionTitle, r.Data.Scores[checkPlayerIndex].CompetitionTitle)`
	`442`	`+ return fmt.Errorf("参加した大会IDが違います (want: %s, got: %s)", competitionTitle, r.Data.Scores[0].CompetitionTitle)`
`443`	`443`	`}`
`444`	`444`	`if int64(100+checkPlayerIndex) != r.Data.Scores[0].Score {`
`445`	`445`	`return fmt.Errorf("スコアが違います (want: %d, got: %d)", 100+checkPlayerIndex, r.Data.Scores[0].Score)`