Merge pull request #144 from isucon/display_name_for_php

fujiwara · web-flow · commit bbeaeb9077a4 · 2022-07-06T10:42:32.000+09:00
PHPでは同一パラメータ名を配列で受け取るときに[]を付ける必要がある
diff --git a/bench/action.go b/bench/action.go
@@ -66,7 +66,7 @@ func GetOrganizerPlayersListAction(ctx context.Context, ag *agent.Agent) (*http.
 func PostOrganizerPlayersAddAction(ctx context.Context, playerDisplayNames []string, ag *agent.Agent) (*http.Response, error) {
 	form := url.Values{}
 	for _, displayName := range playerDisplayNames {
-		form.Add("display_name", displayName)
+		form.Add("display_name[]", displayName)
 	}
 	req, err := ag.POST("/api/organizer/players/add", strings.NewReader(form.Encode()))
 	if err != nil {
diff --git a/webapp/go/isuports.go b/webapp/go/isuports.go
@@ -784,7 +784,7 @@ func playersAddHandler(c echo.Context) error {
 	if err != nil {
 		return fmt.Errorf("error c.FormParams: %w", err)
 	}
-	displayNames := params["display_name"]
+	displayNames := params["display_name[]"]
 
 	pds := make([]PlayerDetail, 0, len(displayNames))
 	for _, displayName := range displayNames {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func GetOrganizerPlayersListAction(ctx context.Context, ag agent.Agent) (http.`
`66`	`66`	`func PostOrganizerPlayersAddAction(ctx context.Context, playerDisplayNames []string, ag agent.Agent) (http.Response, error) {`
`67`	`67`	`form := url.Values{}`
`68`	`68`	`for _, displayName := range playerDisplayNames {`
`69`		`- form.Add("display_name", displayName)`
	`69`	`+ form.Add("display_name[]", displayName)`
`70`	`70`	`}`
`71`	`71`	`req, err := ag.POST("/api/organizer/players/add", strings.NewReader(form.Encode()))`
`72`	`72`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -784,7 +784,7 @@ func playersAddHandler(c echo.Context) error {`
`784`	`784`	`if err != nil {`
`785`	`785`	`return fmt.Errorf("error c.FormParams: %w", err)`
`786`	`786`	`}`
`787`		`- displayNames := params["display_name"]`
	`787`	`+ displayNames := params["display_name[]"]`
`788`	`788`
`789`	`789`	`pds := make([]PlayerDetail, 0, len(displayNames))`
`790`	`790`	`for _, displayName := range displayNames {`