Add parser test and error for free code outside entry #3546
+65
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parser: report error when free code appears outside entry
marsninja
requested changes
Dec 2, 2025
Contributor
marsninja
left a comment
marsninja
left a comment
There was a problem hiding this comment.
This is great, but can we add a test that we dont get teh error if we're in a context where you can use a context manager but dont need a with entry block.
ThakeeNathees
force-pushed
the
fix/parser-free-code-error-test
branch
2 times, most recently
from
8612092 to
eff7ab5
Compare
ThakeeNathees
force-pushed
the
fix/parser-free-code-error-test
branch
from
eff7ab5 to
8dfba1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test ensuring free python code outside with entry reports a parser error. Also includes parser change that logs this specific message.