Skip to content

Commit 9d90466

Browse files
authored
fix(no-export): report on export = usage (#1870)
1 parent e717736 commit 9d90466

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/rules/__tests__/no-export.test.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,12 @@ ruleTester.run('no-export', rule, {
6464
parserOptions: { sourceType: 'module' },
6565
errors: [{ endColumn: 29, column: 1, messageId: 'unexpectedExport' }],
6666
},
67+
{
68+
code: 'export = function() {}; test("a test", () => { expect(1).toBe(1);});',
69+
parser: require.resolve('@typescript-eslint/parser'),
70+
parserOptions: { sourceType: 'module' },
71+
errors: [{ endColumn: 24, column: 1, messageId: 'unexpectedExport' }],
72+
},
6773
{
6874
code: 'module.exports["invalid"] = function() {}; test("a test", () => { expect(1).toBe(1);});',
6975
errors: [{ endColumn: 26, column: 1, messageId: 'unexpectedExport' }],

src/rules/no-export.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export default createRule({
1818
const exportNodes: Array<
1919
| TSESTree.ExportNamedDeclaration
2020
| TSESTree.ExportDefaultDeclaration
21+
| TSESTree.TSExportAssignment
2122
| TSESTree.MemberExpression
2223
> = [];
2324
let hasTestCase = false;
@@ -36,10 +37,11 @@ export default createRule({
3637
hasTestCase = true;
3738
}
3839
},
39-
'ExportNamedDeclaration, ExportDefaultDeclaration'(
40+
'ExportNamedDeclaration, ExportDefaultDeclaration, TSExportAssignment'(
4041
node:
4142
| TSESTree.ExportNamedDeclaration
42-
| TSESTree.ExportDefaultDeclaration,
43+
| TSESTree.ExportDefaultDeclaration
44+
| TSESTree.TSExportAssignment,
4345
) {
4446
exportNodes.push(node);
4547
},

0 commit comments

Comments
 (0)