Skip to content

jquery: Address link text overflow issue on meetings.jquery.org #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 3 commits into from
Dec 2, 2025
Merged

jquery: Address link text overflow issue on meetings.jquery.org #483

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77231c3
Update base.css
HermitShamiko Nov 25, 2025
c4f88c3
Update menu-header.php
HermitShamiko Nov 25, 2025
1475aeb
Update menu-header.php
HermitShamiko Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions themes/jquery/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,6 +1312,7 @@ typesense-minibar[role="option"] mark {

#content a {
text-decoration: underline;
word-break: break-word;
}

#content a:hover {
Expand Down
2 changes: 1 addition & 1 deletion themes/jquery/menu-header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function menu_header_jqueryui_com() {

function menu_header_jquery_org() {
return array(
'https://jquery.org/' => 'Home',
'https://jquery.com/' => 'Home',
Copy link
Member

@mgol mgol Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither org nor home make sense to me here... jquery.org no longer has a home page, and jquery.com is a different site. I'd rather remove this link altogether.

Copy link
Contributor Author

@HermitShamiko HermitShamiko Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the hyperlink from .org means mobile users won't be able to access the jquery.com main page through a prominent shortcut because #global-nav is hidden on mobile devices. Do we really want to do this?
I have a few other questions:

  1. In the PC UI, the Events section of global-nav no longer points to https://events.jquery.org/. Should it be removed?
}9{@RIN%@DBE @}C1BEG$_E
  1. Under menu_header_jquery_org, Support and Team point to https://jquery.org/support/ and https://jquery.org/team/ respectively, and then redirect to https://jquery.com/support/ and https://jquery.com/team/. Should these be replaced with the final domain names?

Copy link
Member

@timmywil timmywil Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.org is intentional and should stay. The jQuery Foundation has become the OpenJS Foundation and the redirect reflects that.

Copy link
Contributor Author

@HermitShamiko HermitShamiko Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.org is intentional and should stay. The jQuery Foundation has become the OpenJS Foundation and the redirect reflects that.

Does this mean that existing links don't need to be changed?

Copy link
Member

@timmywil timmywil Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that existing links don't need to be changed?

Correct. I like the word-break change, though.

Copy link
Member

@mgol mgol Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmywil should we then maybe just change the link to point to https://openjsf.org/ directly, saving the redirect? In most other places we link directly, I think.

Copy link
Member

@timmywil timmywil Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of prefer the redirect. I see it as more historical, but it's not a big preference.

Copy link
Member

@mgol mgol Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmywil in many content repos (although not in this one) we have a spider check workflow which fails if any link redirects. So we actually make sure in CI that we're linking directly. One of the reasons is perhaps that redirects slows down users.

'https://meetings.jquery.org/' => 'Meetings',
'https://jquery.org/team/' => 'Team',
'https://brand.jquery.org/' => 'Brand Guide',
Expand Down