fix: fix resource display when redirecting from /notebooks/* (#148)

echarles · web-flow · commit fa65c00f0c2a · 2022-09-11T19:04:54.000-07:00
diff --git a/nbclassic/notebookapp.py b/nbclassic/notebookapp.py
@@ -272,13 +272,13 @@ def initialize_handlers(self):
         # Default routes
         # Order matters. The first handler to match the URL will handle the request.
         handlers = []
-        # Add a redirect from /notebooks to /edit
+        # Add a redirect from /notebooks to /files
         # for opening non-ipynb files in edit mode.
         handlers.append(
             (
                 rf"/{self.file_url_prefix}/((?!.*\.ipynb($|\?)).*)",
                 RedirectHandler,
-                {"url": self.serverapp.base_url+"edit/{0}"}
+                {"url": self.serverapp.base_url+"files/{0}"}
             )
         )
 

Original file line number	Diff line number	Diff line change
`@@ -272,13 +272,13 @@ def initialize_handlers(self):`
`272`	`272`	`# Default routes`
`273`	`273`	`# Order matters. The first handler to match the URL will handle the request.`
`274`	`274`	`handlers = []`
`275`		`- # Add a redirect from /notebooks to /edit`
	`275`	`+ # Add a redirect from /notebooks to /files`
`276`	`276`	`# for opening non-ipynb files in edit mode.`
`277`	`277`	`handlers.append(`
`278`	`278`	`(`
`279`	`279`	`rf"/{self.file_url_prefix}/((?!.\.ipynb($\|\?)).)",`
`280`	`280`	`RedirectHandler,`
`281`		`- {"url": self.serverapp.base_url+"edit/{0}"}`
	`281`	`+ {"url": self.serverapp.base_url+"files/{0}"}`
`282`	`282`	`)`
`283`	`283`	`)`
`284`	`284`