Skip to content

Commit ad55211

Browse files
authored
Fix(ui): button glow timing and banner placement (#13417)
1 parent fe7849d commit ad55211

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

ui/src/components/flows/TriggerFlow.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<el-button v-if="playgroundStore.enabled" id="run-all-button" :icon="icon.Play" class="el-button--playground" :disabled="isDisabled() || !playgroundStore.readyToStart" @click="playgroundStore.runUntilTask()">
44
{{ $t("playground.run_all_tasks") }}
55
</el-button>
6-
<el-button v-else id="execute-button" :class="{'onboarding-glow': coreStore.guidedProperties.tourStarted}" :icon="icon.LightningBolt" :type="type" :disabled="isDisabled()" @click="onClick()">
6+
<el-button v-else id="execute-button" :class="{'onboarding-glow': coreStore.guidedProperties.glowExecuteButton}" :icon="icon.LightningBolt" :type="type" :disabled="isDisabled()" @click="onClick()">
77
{{ $t("execute") }}
88
</el-button>
99
<el-dialog

ui/src/components/onboarding/VueTour.vue

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,10 @@
353353
highlightElement: ".top-bar",
354354
params: {...STEP_OPTIONS, placement: "bottom"},
355355
before: () => {
356+
coreStore.guidedProperties = {
357+
...coreStore.guidedProperties,
358+
glowExecuteButton: true
359+
};
356360
return wait();
357361
},
358362
},
@@ -369,6 +373,10 @@
369373
placement: "bottom",
370374
},
371375
before: () => {
376+
coreStore.guidedProperties = {
377+
...coreStore.guidedProperties,
378+
glowExecuteButton: false
379+
};
372380
return wait()
373381
},
374382
},
@@ -414,6 +422,7 @@
414422
coreStore.guidedProperties = {
415423
...coreStore.guidedProperties,
416424
tourStarted: false,
425+
glowExecuteButton: false
417426
};
418427
419428
TOURS[TOUR_NAME].stop();
@@ -491,7 +500,7 @@ $flow-image-size-container: 36px;
491500
492501
&.last {
493502
position: fixed;
494-
top: 50%;
503+
top: 75%;
495504
left: 50%;
496505
transform: translate(-50%, -50%);
497506
max-width: $last-step-max-width;

ui/src/stores/core.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ interface GuidedProperties {
99
manuallyContinue: boolean;
1010
template: any;
1111
saveFlow?: boolean;
12+
glowExecuteButton?: boolean;
1213
}
1314

1415
export const useCoreStore = defineStore("core", () => {

0 commit comments

Comments
 (0)