AgentgatewayParameters is now the only way

... to configure a Gateway that uses controller `kgateway.dev/agentgateway`

Breaking change: agentgateway cannot be configured with GatewayParameters. If
you want to use parameters, they must be AgentgatewayParameters.

Signed-off-by: David L. Chandler <[email protected]>

Author: chandler-solo

api/settings/settings.go

@@ -238,12 +238,6 @@ type Settings struct {
 	// EnableExperimentalGatewayAPIFeatures enables kgateway to support experimental features and APIs
 	EnableExperimentalGatewayAPIFeatures bool `split_words:"true" default:"true"`
 
-	// GwpAgwpCompatibility controls whether agentgateway data plane Gateways can use
-	// GatewayParameters. When set to false, only AgentgatewayParameters are allowed,
-	// and using GatewayParameters will result in an error. Defaults to true for
-	// backward compatibility.
-	GwpAgwpCompatibility bool `split_words:"true" default:"true"`
-
 	// GatewayClassParametersRefs configures the GatewayParameters references to set on the default GatewayClasses.
 	// Format: JSON map where keys are GatewayClass names and values are objects with "name" (required),
 	// "namespace" (required), "group" (optional), and "kind" (optional) fields.

api/settings/settings_test.go

@@ -51,7 +51,6 @@ func allEnvVarsSet() map[string]string {
 		"KGW_XDS_AUTH":                                 "false",
 		"KGW_XDS_TLS":                                  "true",
 		"KGW_ENABLE_EXPERIMENTAL_GATEWAY_API_FEATURES": "false",
-		"KGW_GWP_AGWP_COMPATIBILITY":                   "false",
 	}
 }
 
@@ -105,7 +104,6 @@ func TestSettings(t *testing.T) {
 				XdsAuth:                              true,
 				XdsTLS:                               false,
 				EnableExperimentalGatewayAPIFeatures: true,
-				GwpAgwpCompatibility:                 true,
 				GatewayClassParametersRefs:           GatewayClassParametersRefs{},
 			},
 		},
@@ -145,7 +143,6 @@ func TestSettings(t *testing.T) {
 				XdsAuth:                              false,
 				XdsTLS:                               true,
 				EnableExperimentalGatewayAPIFeatures: false,
-				GwpAgwpCompatibility:                 false,
 				GatewayClassParametersRefs: GatewayClassParametersRefs{
 					"kgateway": {
 						Name:      "custom-gwp",
@@ -237,7 +234,6 @@ func TestSettings(t *testing.T) {
 				XdsAuth:                              true,
 				XdsTLS:                               false,
 				EnableExperimentalGatewayAPIFeatures: true,
-				GwpAgwpCompatibility:                 true,
 				GatewayClassParametersRefs:           GatewayClassParametersRefs{},
 			},
 		},

api/v1alpha1/kgateway/gateway_parameters_types.go

@@ -722,13 +722,6 @@ type Agentgateway struct {
 	// +optional
 	Env []corev1.EnvVar `json:"env,omitempty"`
 
-	// Name of the custom configmap to use instead of the default generated one.
-	// When set, the agent gateway will use this configmap instead of creating the default one.
-	// The configmap must contain a 'config.yaml' key with the agent gateway configuration.
-	//
-	// +optional
-	CustomConfigMapName *string `json:"customConfigMapName,omitempty"`
-
 	// Additional volume mounts to add to the container. See
 	// https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#volumemount-v1-core
 	// for details.
@@ -771,10 +764,3 @@ func (in *Agentgateway) GetEnv() []corev1.EnvVar {
 	}
 	return in.Env
 }
-
-func (in *Agentgateway) GetCustomConfigMapName() *string {
-	if in == nil {
-		return nil
-	}
-	return in.CustomConfigMapName
-}

api/v1alpha1/kgateway/zz_generated.deepcopy.go

@@ -58,12 +58,6 @@ spec:
                       EnvoyContainer values will be used by default to configure the data
                       plane proxy.
                     properties:
-                      customConfigMapName:
-                        description: |-
-                          Name of the custom configmap to use instead of the default generated one.
-                          When set, the agent gateway will use this configmap instead of creating the default one.
-                          The configmap must contain a 'config.yaml' key with the agent gateway configuration.
-                        type: string
                       env:
                         description: The container environment variables.
                         items: