Skip to content

Commit e74a135

Browse files
committed
addressed review comment
Signed-off-by: Andy Fong <[email protected]>
1 parent bae31de commit e74a135

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

internal/envoyinit/rustformations/src/http_simple_mutations.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ pub struct FilterConfig {
1919

2020
struct EnvoyTransformationOps<'a> {
2121
envoy_filter: &'a mut dyn EnvoyHttpFilter,
22-
// TODO: see comment for get_random_pattern() below
23-
// random_pattern_map: &'a mut Option<HashMap<String, String>>,
2422
}
2523

2624
impl<'a> EnvoyTransformationOps<'a> {

internal/envoyinit/transformations/src/jinja.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ use std::env;
1919

2020
// These keys are used in a shared scope in the State where we will also put the parsed json body in.
2121
// So, they needs to be as uniq as possible to minimize collision.
22-
const STATE_LOOKUP_KEY_BODY: &str = "body.io.solo";
23-
const STATE_LOOKUP_KEY_CONTEXT: &str = "context.io.solo";
24-
const STATE_LOOKUP_KEY_HEADERS: &str = "headers.io.solo";
25-
const STATE_LOOKUP_KEY_REQ_HEADERS: &str = "request_headers.io.solo";
22+
const STATE_LOOKUP_KEY_BODY: &str = "body.dev.kgateway";
23+
const STATE_LOOKUP_KEY_CONTEXT: &str = "context.dev.kgateway";
24+
const STATE_LOOKUP_KEY_HEADERS: &str = "headers.dev.kgateway";
25+
const STATE_LOOKUP_KEY_REQ_HEADERS: &str = "request_headers.dev.kgateway";
2626

2727
static ENV: Lazy<Environment<'static>> = Lazy::new(new_jinja_env);
2828

test/e2e/tests/base/base_suite.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ func (s *BaseTestingSuite) BeforeTest(suiteName, testName string) {
352352
}
353353

354354
// apply test-specific manifests
355-
fmt.Printf("testName: %s\n", testName)
356355
testCase, ok := s.TestCases[testName]
357356
if !ok {
358357
return

0 commit comments

Comments
 (0)