releases: Adds make build-crds-yaml
#13063
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This paves the way for supporting not just helm for CRD installation but `kubectl apply --server-side -f`. The single YAML file created by the new `make` target would have to be uploaded as an artifact on each Github Release. This was inspired by the release process used by https://github.com/kubernetes-sigs/gateway-api. Verified against the current helm chart by `diff <(go tool helm template install/helm/kgateway-crds) /Users/davidchandler/k_release-has-yaml-artifacts-for-crds/_output/release/kgateway-crds.yaml` Signed-off-by: David L. Chandler <[email protected]>
gateway-bot
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This paves the way for supporting not just helm for CRD installation but
kubectl apply --server-side -f. The single YAML file created by the newmaketarget would have to be uploaded as an artifact on each Github Release.This was inspired by the release process used by
https://github.com/kubernetes-sigs/gateway-api.
Verified against the current helm chart by
diff <(go tool helm template install/helm/kgateway-crds) /Users/davidchandler/k_release-has-yaml-artifacts-for-crds/_output/release/kgateway-crds.yamlChange Type
/kind feature
Changelog
Additional Notes
Not worthy of a changelog unless we go even further.