Skip to content

Conversation

@thejoeejoee
Copy link

@thejoeejoee thejoeejoee commented Nov 14, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Backend of kueueviz switched to strong typed client improving type safety and performance.

Which issue(s) this PR fixes:

Fixes #6383

Special notes for your reviewer:

controller-runtime setup prepared for future shared-informers integration

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thejoeejoee
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 14, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: thejoeejoee / name: Josef Kolář (89c3573)

@k8s-ci-robot
Copy link
Contributor

Welcome @thejoeejoee!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @thejoeejoee. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 14, 2025
@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 89c3573
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69259d40d91932000899b870

@thejoeejoee thejoeejoee changed the title WIP: kueueviz/backend: use typed go-client [WIP] WIP: kueueviz/backend: use typed go-client Nov 14, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 14, 2025
@tenzen-y
Copy link
Member

Thank you for working on that!
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2025
@thejoeejoee thejoeejoee force-pushed the main branch 2 times, most recently from 2eabfe9 to b689452 Compare November 16, 2025 18:27
@thejoeejoee thejoeejoee force-pushed the main branch 5 times, most recently from 8d95308 to 008b0af Compare November 24, 2025 21:54
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 24, 2025
@thejoeejoee thejoeejoee force-pushed the main branch 2 times, most recently from cfa6005 to 9277862 Compare November 24, 2025 22:25
@thejoeejoee
Copy link
Author

/retest

@thejoeejoee thejoeejoee marked this pull request as ready for review November 25, 2025 06:11
@thejoeejoee thejoeejoee changed the title WIP: kueueviz/backend: use typed go-client kueueviz/backend: use typed client Nov 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 25, 2025

This requires review of code still, maybe @akram or @kannon92 can find someone?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 25, 2025

@thejoeejoee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-e2e-main-1-32 89c3573 link true /test pull-kueue-test-e2e-main-1-32

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dashboard] Use kueue go bindings rather than dynamic client

4 participants