-
Notifications
You must be signed in to change notification settings - Fork 479
Remove FlavorFungibilityImplicitPreferenceDefault feature gate. #8134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove FlavorFungibilityImplicitPreferenceDefault feature gate. #8134
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mbobrovskyi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| } | ||
|
|
||
| // PreemptionOverBorrowing preference | ||
| if fungibilityConfig.WhenCanBorrow == kueue.TryNextFlavor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually when FlavorFungibilityImplicitPreferenceDefault was enabled and
WhenCanBorrow: TryNextFlavor
WhenCanPreempt: MayStopSearch
then we we would choose preemptionOverBorrowing. Now we will use borrowingOverPreemption.
I think it makes sense to use preemptionOverBorrowing when this configuration is used. Wdyt @tenzen-y @pajakd ?
cc @amy
65212c1 to
1ae4923
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Remove FlavorFungibilityImplicitPreferenceDefault feature gate.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?