Skip to content

Conversation

@mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Dec 8, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove FlavorFungibilityImplicitPreferenceDefault feature gate.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed FlavorFungibilityImplicitPreferenceDefault feature gate.

ACTION REQUIRED: Configure flavor selection preference using the ClusterQueue field `spec.flavorFungibility.preference` instead.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 1ae4923
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6936f5b4c800b20008da999d
😎 Deploy Preview https://deploy-preview-8134--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2025
}

// PreemptionOverBorrowing preference
if fungibilityConfig.WhenCanBorrow == kueue.TryNextFlavor {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually when FlavorFungibilityImplicitPreferenceDefault was enabled and
WhenCanBorrow: TryNextFlavor
WhenCanPreempt: MayStopSearch

then we we would choose preemptionOverBorrowing. Now we will use borrowingOverPreemption.

I think it makes sense to use preemptionOverBorrowing when this configuration is used. Wdyt @tenzen-y @pajakd ?

cc @amy

@mbobrovskyi mbobrovskyi force-pushed the cleanup/remove-FlavorFungibilityImplicitPreferenceDefault-feature branch from 65212c1 to 1ae4923 Compare December 8, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants