Change error code for create snapshot to a non-final error

Author: xing-yang

pkg/csi/service/wcpguest/controller.go

@@ -1647,7 +1647,11 @@ func (c *controller) CreateSnapshot(ctx context.Context, req *csi.CreateSnapshot
 			msg := fmt.Sprintf("volumesnapshot: %s on namespace: %s in supervisor cluster was not Ready. "+
 				"Error: %+v", supervisorVolumeSnapshotName, c.supervisorNamespace, err)
 			log.Error(msg)
-			return nil, status.Error(codes.Internal, msg)
+			// Note: Set the return code to codes.DeadlineExceeded if VolumeSnapshot is still not ready
+			// to indicate that the snapshot creation has timed out
+			// so that external-snapshotter will keep retrying and won't leave
+			// orphan snapshots behind.
+			return nil, status.Error(codes.DeadlineExceeded, msg)
 		}
 		// Extract the fcd-id + snapshot-id annotation from the supervisor volumesnapshot CR
 		snapshotID := vs.Annotations[common.VolumeSnapshotInfoKey]