-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix Netlify build failure from template syntax error and PATH issues in documentation #17767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: hakman <[email protected]>
|
@copilot deploy/netlify is still failing, fix it |
…and excluding conflicting README.md Co-authored-by: hakman <[email protected]>
Co-authored-by: hakman <[email protected]>
|
@copilot 4:11:40 PM: Successfully installed MarkupSafe-3.0.3 babel-2.17.0 backrefs-5.9 certifi-2025.11.12 charset_normalizer-3.4.4 click-8.2.1 colorama-0.4.6 ghp-import-2.1.0 hjson-3.1.0 idna-3.11 jinja2-3.1.6 markdown-3.10 mergedeep-1.3.4 mkdocs-1.6.1 mkdocs-get-deps-0.2.0 mkdocs-macros-plugin-1.3.7 mkdocs-material-9.6.19 mkdocs-material-extensions-1.3.1 packaging-25.0 paginate-0.5.7 pathspec-0.12.1 platformdirs-4.5.0 pygments-2.19.2 pymdown-extensions-10.17.1 python-dateutil-2.9.0.post0 pyyaml-6.0.3 pyyaml-env-tag-1.1 requests-2.32.5 six-1.17.0 super-collections-0.6.2 termcolor-3.2.0 urllib3-2.5.0 watchdog-6.0.0 |
Co-authored-by: hakman <[email protected]>
Fixed in cf9e438. The issue was that |
mkdocs.yml
Outdated
| repo_name: 'kubernetes/kops' | ||
| repo_url: 'https://github.com/kubernetes/kops' | ||
| site_url: 'https://kops.sigs.k8s.io' | ||
| exclude_docs: README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in f12bb70. The exclude_docs: README.md line has been removed from mkdocs.yml. The README.md warning still appears but mkdocs automatically handles it by excluding README.md in favor of index.md.
Co-authored-by: hakman <[email protected]>
|
@copilot squash the commits |
I've squashed the 6 commits locally into a single commit (f227b80), but the automated push tool cannot force-push to update the remote branch. The squashed commit contains all the changes with a clean commit message. A force push to the branch is needed to complete the squash, which requires manual intervention or different tooling permissions. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/override pull-kops-e2e-k8s-aws-amazonvpc |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc, pull-kops-e2e-k8s-aws-calico, pull-kops-e2e-k8s-gce-cilium, pull-kops-e2e-k8s-gce-ipalias In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
The Netlify documentation build was failing due to multiple issues. This PR fixes three issues that were causing build failures:
{{ .ID }}(Scaleway CLI's Go template syntax) as a Jinja2 macro, causing:Wrapped the Go template syntax with
{% raw %}/{% endraw %}tags to prevent macro processing while preserving the literal text.Missing canal.md reference: Removed reference to non-existent
networking/canal.mdfrom the navigation configuration, which was causing a warning.mkdocs command not found: Changed
mkdocs buildtopython -m mkdocs buildin the Makefile because themkdocsexecutable wasn't in Netlify's PATH afterpip install, causing:Changes made:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes the failing Netlify tests
Special notes for your reviewer:
The build now passes successfully. Other documentation files already use similar escaping patterns (
{{ '{{ ... }}' }}). This fix aligns with that approach using the raw tag method. Usingpython -m mkdocsensures the module can be executed regardless of PATH configuration. MkDocs automatically handles the README.md/index.md conflict by excluding README.md and issuing a warning.Note: The commits have been squashed locally into a single commit (f227b80c) but require a force push to update the remote branch, which may need manual intervention.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.