ci: add smoke test to github action (#21095)

* smoke test

* add logic to detect nested VMs

* increase memory to 8gb for tesT

* use the network flag for both qemu and vfkit

* code review comments

* separate minikube download

* separate minikube download

* force cpu1

* add docker for smoke test

* exclude envs dont need in matrix

* change back to 3

* remove unused code

* add info block for linux as well

Author: medyagh

.github/workflows/smoke-test.yml

@@ -0,0 +1,99 @@
+# Boot Smoke Test only tests Bare VM (start,stop,delete) and not any minikube/kubernetes functionality.
+name: Boot Smoke Test
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+  workflow_dispatch:
+env:
+  GOPROXY: https://proxy.golang.org
+  permissions:
+  contents: read
+jobs:
+  minikube-vm-boot:
+    name: Boot Smoke Test
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - driver: qemu
+            os: macos-13
+            network_flag: --network socket_vmnet
+          - driver: docker
+            os: ubuntu-24.04
+            network_flag: ""
+    steps:
+      - name: Info Block (macos)
+        if: contains(matrix.os, 'macos')
+        shell: bash
+        run: |
+          uname -a
+          sysctl -n hw.memsize
+          echo "$(sysctl -n hw.memsize) / 1024 / 1024 / 1024" | bc
+          sysctl -n hw.ncpu
+          sysctl -n machdep.cpu.brand_string
+          sysctl hw.model
+          sysctl -n kern.hv_vmm_present
+          sysctl -n kern.hv_support
+          system_profiler SPHardwareDataType
+          sw_vers
+          ifconfig
+      - name: Info Block (linux)
+        if: contains(matrix.os, 'ubuntu')
+        shell: bash
+        run: |
+            uname -a
+            grep MemTotal /proc/meminfo
+            awk '/MemTotal/ {printf "%.2f\n", $2 / 1024 / 1024}' /proc/meminfo
+            nproc
+            grep 'model name' /proc/cpuinfo | head -n1
+            # System model (requires `dmidecode`, may need sudo)
+            sudo dmidecode -s system-product-name
+            systemd-detect-virt
+            # Check if KVM is available (can show virtualization support)
+            egrep -c '(vmx|svm)' /proc/cpuinfo
+            # Detailed hardware info (like `system_profiler`)
+            sudo lshw -short
+            cat /etc/os-release
+            ip addr show
+            ifconfig
+            docker version
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5
+        with:
+          go-version-file: go.mod
+          cache: true
+      - name: Download Golang Dependencies
+        run: go mod download
+      - name: Build Binaries
+        run: make
+      - name: Ensure bootpd is enabled
+        if: contains(matrix.os, 'macos')
+        shell: bash
+        run: |
+          set -x
+          fw=/usr/libexec/ApplicationFirewall/socketfilterfw
+          sudo $fw --remove /usr/libexec/bootpd
+          sudo $fw --add /usr/libexec/bootpd
+          sudo $fw --unblock /usr/libexec/bootpd
+      - name: brew update
+        if: contains(matrix.os, 'macos')
+        run:
+          brew update
+      - name: Install qemu and socket_vmnet (macos)
+        if: contains(matrix.os, 'macos') && matrix.driver == 'qemu'
+        run: |
+          brew install qemu socket_vmnet
+          HOMEBREW=$(which brew) && sudo ${HOMEBREW} services start socket_vmnet          
+      - name: Minikube Download only (iso/image)
+        run:
+          ./out/minikube start --download-only --driver=${{ matrix.driver }} 
+      - name: Start minikube (1st boot)
+        run: ./out/minikube start --driver=${{ matrix.driver }} ${{ matrix.network_flag }} --memory 4gb --no-kubernetes --alsologtostderr 
+      - name: Stop minikube
+        run: ./out/minikube stop
+      - name: Start minikube again (2nd boot)
+        run: ./out/minikube start --alsologtostderr
+      - name: delete minikube 
+        run: ./out/minikube delete --alsologtostderr

pkg/drivers/hyperkit/driver.go

@@ -38,6 +38,7 @@ import (
 	hyperkit "github.com/moby/hyperkit/go"
 	"github.com/pkg/errors"
 	pkgdrivers "k8s.io/minikube/pkg/drivers"
+	"k8s.io/minikube/pkg/minikube/detect"
 )
 
 const (
@@ -296,7 +297,11 @@ func (d *Driver) setupIP(mac string) error {
 	var err error
 
 	// Implement a retry loop without calling any minikube code
-	for i := 0; i < 30; i++ {
+	multiplier := 1
+	if detect.NestedVM() {
+		multiplier = 3 // will help with running in Free github action Macos VMs (takes 112+ retries on average)
+	}
+	for i := 0; i < 60*multiplier; i++ {
 		log.Debugf("Attempt %d", i)
 		err = getIP()
 		if err == nil {

pkg/drivers/qemu/qemu.go

@@ -517,7 +517,11 @@ func (d *Driver) Start() error {
 			return nil
 		}
 		// Implement a retry loop because IP address isn't added to dhcp leases file immediately
-		for i := 0; i < 60; i++ {
+		multiplier := 1
+		if detect.NestedVM() {
+			multiplier = 3 // will help with running in Free github action Macos VMs (takes 112+ retries on average)
+		}
+		for i := 0; i < 60*multiplier; i++ {
 			log.Debugf("Attempt %d", i)
 			err = getIP()
 			if err == nil {

pkg/drivers/vfkit/vfkit.go

@@ -44,6 +44,7 @@ import (
 	"k8s.io/klog/v2"
 	pkgdrivers "k8s.io/minikube/pkg/drivers"
 	"k8s.io/minikube/pkg/drivers/vmnet"
+	"k8s.io/minikube/pkg/minikube/detect"
 	"k8s.io/minikube/pkg/minikube/exit"
 	"k8s.io/minikube/pkg/minikube/firewall"
 	"k8s.io/minikube/pkg/minikube/out"
@@ -309,7 +310,11 @@ func (d *Driver) setupIP(mac string) error {
 		return nil
 	}
 	// Implement a retry loop because IP address isn't added to dhcp leases file immediately
-	for i := 0; i < 60; i++ {
+	multiplier := 1
+	if detect.NestedVM() {
+		multiplier = 3 // will help with running in Free github action Macos VMs (takes 160+ retries on average)
+	}
+	for i := 0; i < 60*multiplier; i++ {
 		log.Debugf("Attempt %d", i)
 		err = getIP()
 		if err == nil {

pkg/minikube/detect/detect.go

@@ -212,3 +212,30 @@ func MacOS13Plus() bool {
 	}
 	return major >= 13
 }
+
+// NestedVM returns true if the current machine is running a nested VM (like in MacOs in Github Action)
+// this func tries its best but not guaranteed to be 100% accurate, and if not sure will return false (default behaviour).
+func NestedVM() bool {
+	if runtime.GOOS == "linux" {
+		c := exec.Command("systemd-detect-virt", "--quiet")
+		_, err := c.Output()
+		if err == nil {
+			klog.Infof("nested VM detected")
+			return true
+		}
+		return false // On a bare-metal system, it exits with code 1 and outputs "none".
+
+	}
+
+	if runtime.GOOS == "darwin" {
+		c := exec.Command("sysctl", "-n", "kern.hv_vmm_present")
+		o, err := c.Output()
+		if err != nil {
+			klog.Warningf("Failed to check for nested VM: %v", err)
+			return false
+		}
+		klog.Infof("nested VM detected, %s", o)
+		return true
+	}
+	return false
+}