Merge pull request #21492 from medyagh/vmnet_mirror

update url for vmnet-helper

Author: medyagh

.github/workflows/functional_test.yml

@@ -377,11 +377,7 @@ jobs:
         if: matrix.os == 'macos-13' && matrix.driver == 'vfkit'
         run: |
           brew install vfkit
-          machine="$(uname -m)"
-          archive="vmnet-helper-$machine.tar.gz"
-          curl -LOf "https://github.com/nirs/vmnet-helper/releases/latest/download/$archive"
-          sudo tar xvf "$archive" -C / opt/vmnet-helper
-          sudo install -m 0640 /opt/vmnet-helper/share/doc/vmnet-helper/sudoers.d/vmnet-helper /etc/sudoers.d/
+          curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash -s
       - name: Download Test Binaries
         uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0
         with:

.github/workflows/smoke-test.yml

@@ -112,11 +112,7 @@ jobs:
         if: matrix.driver == 'vfkit'
         run: |
           brew install vfkit
-          machine="$(uname -m)"
-          archive="vmnet-helper-$machine.tar.gz"
-          curl -LOf "https://github.com/nirs/vmnet-helper/releases/latest/download/$archive"
-          sudo tar xvf "$archive" -C / opt/vmnet-helper
-          sudo install -m 0640 /opt/vmnet-helper/share/doc/vmnet-helper/sudoers.d/vmnet-helper /etc/sudoers.d/
+          curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash -s
       - name: Install qemu and socket_vmnet (macos)
         if: matrix.os == 'macos-13' && matrix.driver == 'qemu'
         run: |

pkg/minikube/reason/reason.go

@@ -556,7 +556,7 @@ var (
 
 		Please install vmnet-helper using these instructions:
 
-		https://github.com/nirs/vmnet-helper#installation`),
+			curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash`),
 		Style: style.SeeNoEvil,
 	}
 	NotConfiguredVmnetHelper = Kind{
@@ -565,8 +565,7 @@ var (
 		Advice: translate.T(`Configure vmnet-helper to run without a password.
 
 		Please install a vmnet-helper sudoers rule using these instructions:
-
-		https://github.com/nirs/vmnet-helper#granting-permission-to-run-vmnet-helper`),
+			curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash`),
 		Style: style.SeeNoEvil,
 	}
 )

site/content/en/docs/drivers/krunkit.md

@@ -37,11 +37,7 @@ instructions below.
 ### Install vment-helper
 
 ```shell
-machine="$(uname -m)"
-archive="vmnet-helper-$machine.tar.gz"
-curl -LOf "https://github.com/nirs/vmnet-helper/releases/latest/download/$archive"
-sudo tar xvf "$archive" -C / opt/vmnet-helper
-rm "$archive"
+    curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash
 ```
 
 The command downloads the latest release from github and installs it to
@@ -51,19 +47,24 @@ The command downloads the latest release from github and installs it to
 > The vmnet-helper executable and the directory where it is installed
 > must be owned by root and may not be modifiable by unprivileged users.
 
-### Grant permission to run vmnet-helper
+### Grant permission to run vmnet-helper manually (if said no to script above)
+
 
 The vment-helper process must run as root to create a vmnet interface.
 To allow users in the `staff` group to run the vmnet helper without a
 password, you can install the default sudoers rule:
 
+The installation script will ask your permission to add to the sudoers but if you say no and prefer to do manually here is the command:
+
 ```shell
 sudo install -m 0640 /opt/vmnet-helper/share/doc/vmnet-helper/sudoers.d/vmnet-helper /etc/sudoers.d/
 ```
 
 You can change the sudoers configuration to allow access to specific
 users or other groups.
 
+
+
 ### Usage
 
 ```shell

site/content/en/docs/drivers/vfkit.md

@@ -35,25 +35,15 @@ installation instructions below.
 ### Install vment-helper
 
 ```shell
-machine="$(uname -m)"
-archive="vmnet-helper-$machine.tar.gz"
-curl -LOf "https://github.com/nirs/vmnet-helper/releases/latest/download/$archive"
-sudo tar xvf "$archive" -C / opt/vmnet-helper
-rm "$archive"
+curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash
 ```
 
 The command downloads the latest release from github and installs it to
 `/opt/vmnet-helper`.
 
-**IMPORTANT**: The vmnet-helper executable and the directory where it is
-installed must be owned by root and may not be modifiable by
-unprivileged users.
+### Grant permission to run vmnet-helper manually (if said no to script above)
 
-### Grant permission to run vmnet-helper
-
-The vment-helper process must run as root to create a vmnet interface.
-To allow users in the `staff` group to run the vmnet helper without a
-password, you can install the default sudoers rule:
+vmnet-helper must run as root to create a vmnet interface. To let users in the staff group run it without a password, install the default sudoers rule. The install script offers to add this automatically; if you declined, run the command below manually:
 
 ```shell
 sudo install -m 0640 /opt/vmnet-helper/share/doc/vmnet-helper/sudoers.d/vmnet-helper /etc/sudoers.d/
@@ -62,6 +52,12 @@ sudo install -m 0640 /opt/vmnet-helper/share/doc/vmnet-helper/sudoers.d/vmnet-he
 You can change the sudoers configuration to allow access to specific
 users or other groups.
 
+
+**IMPORTANT**: The vmnet-helper executable and the directory where it is
+installed must be owned by root and may not be modifiable by
+unprivileged users.
+
+
 ### Usage
 
 ```shell

translations/de.json

@@ -124,7 +124,7 @@
 	"Configure an external network switch following the official documentation, then add `--hyperv-virtual-switch=\u003cswitch-name\u003e` to `minikube start`": "Konfigurieren Sie einen externen Netzwerk-Switch mit Hilfe der offiziellen Dokumentation, dann fügen Sie `--hyperv-virtual-switch=\u003cswitch-name\u003e` zum Start-Befehl `minikube start` hinzu",
 	"Configure environment to use minikube's Docker daemon": "Konfiguriere die Umgebung um Minikubes Docker daemon zu verwenden",
 	"Configure environment to use minikube's Podman service": "Konfiguriere die Umgebung um Minikubes Podman Service zu verwenden",
-	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#granting-permission-to-run-vmnet-helper": "",
+	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"Configures the addon w/ADDON_NAME within minikube (example: minikube addons configure registry-creds). For a list of available addons use: minikube addons list": "Konfiguriert das Addon mit Name ADDON_NAME in Minikube (Beispiel: minikube addons configure registry-creds). Eine Liste aller verfügbaren Addons erhält man mit: minikube addons list",
 	"Configuring RBAC rules ...": "Konfiguriere RBAC Regeln ...",
 	"Configuring local host environment ...": "Konfiguriere Umgebung des lokalen Hosts ...",
@@ -1174,7 +1174,7 @@
 	"using metrics-server addon, heapster is deprecated": "Verwende Metrics-Server Addon, heapster ist veraltet (deprecated)",
 	"version json failure": "version json Fehler",
 	"version yaml failure": "version yaml Fehler",
-	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#installation": "",
+	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"yaml encoding failure": "Yaml Encoding Fehler",
 	"zsh completion failed": "zsh completion fehlgeschlagen",
 	"zsh completion.": "",

translations/el.json

@@ -109,6 +109,7 @@
 	"Configure a default route on this Linux host, or use another --driver that does not require it": "",
 	"Configure an external network switch following the official documentation, then add `--hyperv-virtual-switch=\u003cswitch-name\u003e` to `minikube start`": "",
 	"Configure environment to use minikube's Podman service": "Διαμόρφωση περιβάλλοντος για χρήση της υπηρεσίας Podman του minikube",
+	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#granting-permission-to-run-vmnet-helper": "Διαμορφώστε το vmnet-helper ώστε να εκτελείται χωρίς κωδικό πρόσβασης.\n\n\t\tΕγκαταστήστε έναν κανόνα sudoers vmnet-helper χρησιμοποιώντας αυτές τις οδηγίες:\n\n\t\thttps://github.com/nirs/vmnet-helper#granting-permission-to-run-vmnet-helper",
 	"Configures the addon w/ADDON_NAME within minikube (example: minikube addons configure registry-creds). For a list of available addons use: minikube addons list": "Διαμορφώνει το πρόσθετο με ADDON_NAME εντός του minikube (παράδειγμα: minikube addons configure registry-creds). Για μια λίστα με τα διαθέσιμα πρόσθετα χρησιμοποιήστε: minikube addons list",
 	"Configuring RBAC rules ...": "Διαμόρφωση κανόνων RBAC ...",
@@ -1047,7 +1048,7 @@
 	"usage: minikube profile [MINIKUBE_PROFILE_NAME]": "",
 	"version json failure": "",
 	"version yaml failure": "",
-	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#installation": "",
+	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"yaml encoding failure": "",
 	"zsh completion failed": "",
 	"zsh completion.": "",

translations/es.json

@@ -121,7 +121,7 @@
 	"Configure an external network switch following the official documentation, then add `--hyperv-virtual-switch=\u003cswitch-name\u003e` to `minikube start`": "Configura un switch de red externo siguiendo la documentación oficial, y luego añade `--hyperv-virtual-switch=\u003cswitch-name\u003e` a `minikube start`",
 	"Configure environment to use minikube's Docker daemon": "Configura un entorno para usar el Docker daemon de minikube",
 	"Configure environment to use minikube's Podman service": "Configura un entorno para usar el servicio Podman de minikube",
-	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#granting-permission-to-run-vmnet-helper": "",
+	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"Configures the addon w/ADDON_NAME within minikube (example: minikube addons configure registry-creds). For a list of available addons use: minikube addons list": "Configura los complementos dentro de minikube con ADDON_NAME (Por ejemplo: minikube addons configure registry-creds). Para ver los complementos disponibles usa: minikube addons list",
 	"Configuring RBAC rules ...": "Configurando reglas RBAC...",
 	"Configuring local host environment ...": "Configuranto entorno del host local ...",
@@ -1116,7 +1116,7 @@
 	"usage: minikube profile [MINIKUBE_PROFILE_NAME]": "",
 	"version json failure": "",
 	"version yaml failure": "",
-	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#installation": "",
+	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"yaml encoding failure": "",
 	"zsh completion failed": "Falló el autocompletado de zsh",
 	"zsh completion.": "autocompletado zsh",

translations/fr.json

@@ -125,6 +125,7 @@
 	"Configure an external network switch following the official documentation, then add `--hyperv-virtual-switch=\u003cswitch-name\u003e` to `minikube start`": "Configurez un commutateur réseau externe en suivant la documentation officielle, puis ajoutez `--hyperv-virtual-switch=\u003cswitch-name\u003e` à `minikube start`",
 	"Configure environment to use minikube's Docker daemon": "Configurer l'environnement pour utiliser le démon Docker de minikube",
 	"Configure environment to use minikube's Podman service": "Configurer l'environnement pour utiliser le service Podman de minikube",
+	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#granting-permission-to-run-vmnet-helper": "Configurez vmnet-helper pour qu'il s'exécute sans mot de passe.\n\n\t\tVeuillez installer une règle sudoers vmnet-helper en suivant ces instructions :\n\n\t\thttps://github.com/nirs/vmnet-helper#granting-permission-to-run-vmnet-helper",
 	"Configures the addon w/ADDON_NAME within minikube (example: minikube addons configure registry-creds). For a list of available addons use: minikube addons list": "Configure le module w/ADDON_NAME dans minikube (exemple : minikube addons configure registry-creds). Pour une liste des modules disponibles, utilisez : minikube addons list",
 	"Configuring RBAC rules ...": "Configuration des règles RBAC ...",
@@ -1163,6 +1164,7 @@
 	"version json failure": "échec de la version du JSON",
 	"version yaml failure": "échec de la version du YAML",
 	"vmnet-helper was not found on the system, resolve by:\n\n\t\tOption 1) Installing vmnet-helper:\n\n\t\t  https://github.com/nirs/vmnet-helper#installation\n\n\t\tOption 2) Using the nat network:\n\n\t\t  minikube start{{.profile}} --driver vfkit --network nat": "vmnet-helper n'a pas été trouvé sur le système, résolvez le problème par :\n\n\t\tOption 1) Installation de vmnet-helper :\n\n\t\t https://github.com/nirs/vmnet-helper#installation\n\n\t\tOption 2) Utilisation du réseau NAT :\n\n\t\t minikube start{{.profile}} --driver vfkit --network nat",
+	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#installation": "vmnet-helper est introuvable sur le système.\n\n\t\tVeuillez installer vmnet-helper en suivant ces instructions :\n\n\t\thttps://github.com/nirs/vmnet-helper#installation",
 	"yaml encoding failure": "échec de l'encodage yaml",
 	"zsh completion failed": "complétion de zsh en échec",

translations/id.json

@@ -111,7 +111,7 @@
 	"Configure a default route on this Linux host, or use another --driver that does not require it": "Konfigurasikan rute default pada host Linux ini, atau gunakan --driver lain yang tidak memerlukannya",
 	"Configure an external network switch following the official documentation, then add `--hyperv-virtual-switch=\u003cswitch-name\u003e` to `minikube start`": "Konfigurasikan external network switch dengan mengikuti dokumentasi resmi, lalu tambahkan argumen `--hyperv-virtual-switch=\u003cswitch-name\u003e` ke `minikube start`",
 	"Configure environment to use minikube's Podman service": "Konfigurasikan environment untuk menggunakan layanan Podman minikube",
-	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#granting-permission-to-run-vmnet-helper": "",
+	"Configure vmnet-helper to run without a password.\n\n\t\tPlease install a vmnet-helper sudoers rule using these instructions:\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"Configures the addon w/ADDON_NAME within minikube (example: minikube addons configure registry-creds). For a list of available addons use: minikube addons list": "Mengonfigurasi add-on dengan ADDON_NAME dalam minikube (contoh: minikube addons configure registry-creds). Untuk daftar add-on yang tersedia, gunakan:  minikube addons list",
 	"Configuring RBAC rules ...": "Konfigurasi aturan RBAC...",
 	"Configuring local host environment ...": "Mengonfigurasi environment host lokal ...",
@@ -1053,7 +1053,7 @@
 	"usage: minikube profile [MINIKUBE_PROFILE_NAME]": "Penggunaan: minikube profile [MINIKUBE_PROFILE_NAME]",
 	"version json failure": "Gagal mendapatkan versi dalam format JSON",
 	"version yaml failure": "Gagal mendapatkan versi dalam format YAML",
-	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\thttps://github.com/nirs/vmnet-helper#installation": "",
+	"vmnet-helper was not found on the system.\n\n\t\tPlease install vmnet-helper using these instructions:\n\n\t\t\tcurl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash": "",
 	"yaml encoding failure": "Gagal melakukan encoding YAML",
 	"zsh completion failed": "zsh completion gagal",
 	"zsh completion.": "zsh completio",