Merge pull request #21341 from nirs/krunkit-no-offloading

krunkit: Disable offloading for faster networking

Author: medyagh

pkg/drivers/krunkit/krunkit.go

@@ -229,7 +229,8 @@ func (d *Driver) startKrunkit(socketPath string) error {
 		"--memory", fmt.Sprintf("%d", d.Memory),
 		"--cpus", fmt.Sprintf("%d", d.CPU),
 		"--restful-uri", d.restfulURI(),
-		"--device", fmt.Sprintf("virtio-net,unixSocketPath=%s,mac=%s", socketPath, d.MACAddress),
+		"--device", fmt.Sprintf("virtio-net,type=unixgram,path=%s,mac=%s,offloading=%t",
+			socketPath, d.MACAddress, d.VmnetHelper.Offloading),
 		"--device", fmt.Sprintf("virtio-serial,logFilePath=%s", d.serialPath()),
 		"--krun-log-level", logLevelInfo,
 

pkg/minikube/registry/drvs/krunkit/krunkit.go

@@ -86,8 +86,6 @@ func configure(cfg config.ClusterConfig, n config.Node) (interface{}, error) {
 		VmnetHelper: vmnet.Helper{
 			MachineDir:  filepath.Join(storePath, "machines", machineName),
 			InterfaceID: u,
-			// Required Until https://github.com/containers/libkrun/issues/264 is fixed.
-			Offloading: true,
 		},
 	}, nil
 }

site/content/en/docs/drivers/krunkit.md

@@ -16,7 +16,7 @@ workloads.
 - Available only on Apple silicon.
 - Requires macOS 13 or later.
 - Requires minikube version 1.37.0 or later.
-- Requires krunkit version 0.2.2 or later.
+- Requires krunkit version 1.0.0 or later.
 - Requires [vmnet-helper](https://github.com/nirs/vmnet-helper).
 
 ## Installing krunkit