Skip to content

Commit ba14f47

Browse files
committed
improves tests
Signed-off-by: Mior Muhammad Zaki <[email protected]>
1 parent ac63949 commit ba14f47

File tree

4 files changed

+24
-4
lines changed

4 files changed

+24
-4
lines changed

tests/Integration/Http/Resources/JsonApi/Fixtures/Profile.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33
namespace Illuminate\Tests\Integration\Http\Resources\JsonApi\Fixtures;
44

55
use Illuminate\Database\Eloquent\Attributes\UseFactory;
6+
use Illuminate\Database\Eloquent\Attributes\UseResource;
67
use Illuminate\Database\Eloquent\Factories\HasFactory;
78
use Illuminate\Database\Eloquent\Model;
89

10+
#[UseResource(ProfileResource::class)]
911
#[UseFactory(ProfileFactory::class)]
1012
class Profile extends Model
1113
{
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
<?php
2+
3+
namespace Illuminate\Tests\Integration\Http\Resources\JsonApi\Fixtures;
4+
5+
use Illuminate\Http\Request;
6+
use Illuminate\Http\Resources\JsonApi\JsonApiResource;
7+
8+
class ProfileResource extends JsonApiResource
9+
{
10+
protected array $relationships = [
11+
'user' => UserResource::class,
12+
];
13+
14+
#[\Override]
15+
public function toAttributes(Request $request)
16+
{
17+
return [
18+
'timezone' => $this->timezone,
19+
'date_of_birth' => $this->date_of_birth,
20+
];
21+
}
22+
}

tests/Integration/Http/Resources/JsonApi/JsonApiCollectionTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,6 @@ public function testItCanGenerateJsonApiResponseWithRelationshipsUsingSparseIncl
148148
'id' => (string) $profile->getKey(),
149149
'type' => 'profiles',
150150
'attributes' => [
151-
'id' => $profile->getKey(),
152-
'user_id' => $user->getKey(),
153151
'date_of_birth' => '2011-06-09',
154152
'timezone' => 'America/Chicago',
155153
],

tests/Integration/Http/Resources/JsonApi/JsonApiResourceTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,7 @@ public function testItCanGenerateJsonApiResponseWithRelationshipsUsingSparseIncl
131131
'type' => 'profiles',
132132
'attributes' => [
133133
'date_of_birth' => '2011-06-09',
134-
'id' => $profile->getKey(),
135134
'timezone' => 'America/Chicago',
136-
'user_id' => $user->getKey(),
137135
],
138136
],
139137
[

0 commit comments

Comments
 (0)