cleaning php mess

Author: TamaroWalter

backup/moodle2/backup_moodleoverflow_stepslib.php

@@ -74,9 +74,6 @@ protected function define_structure() {
         $read = new backup_nested_element('read', ['id'], [
             'userid', 'discussionid', 'postid', 'firstread', 'lastread', ]);
 
-        $grades = new backup_nested_element('grades');
-        $grade = new backup_nested_element('grade', ['id'], ['userid', 'grade']);
-
         $tracking = new backup_nested_element('tracking');
         $track = new backup_nested_element('track', ['id'], ['userid']);
 

backup/moodle2/restore_moodleoverflow_activity_task.class.php

@@ -107,72 +107,17 @@ public static function define_decode_rules() {
     public static function define_restore_log_rules() {
         $rules = [];
 
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'add',
-            'view.php?id={course_module}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'update',
-            'view.php?id={course_module}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'view',
-            'view.php?id={course_module}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'view moodleoverflow',
-            'view.php?id={course_module}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'mark read',
-            'view.php?f={moodleoverflow}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'start tracking',
-            'view.php?f={moodleoverflow}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'stop tracking',
-            'view.php?f={moodloeoverflow}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'subscribe',
-            'view.php?f={moodleoverflow}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'unsubscribe',
-            'view.php?f={moodleoverflow}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'subscriber',
-            'subscribers.php?id={moodleoverflow}',
-            '{moodleoverflow}'
-        );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'subscribers',
-            'subscribers.php?id={moodleoverflow}',
-            '{moodleoverflow}'
-        );
+        $rules[] = new restore_log_rule('moodleoverflow', 'add', 'view.php?id={course_module}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'update', 'view.php?id={course_module}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'view', 'view.php?id={course_module}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'view moodleoverflow', 'view.php?id={course_module}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'mark read', 'view.php?f={moodleoverflow}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'start tracking', 'view.php?f={moodleoverflow}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'stop tracking', 'view.php?f={moodloeoverflow}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'subscribe', 'view.php?f={moodleoverflow}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'unsubscribe', 'view.php?f={moodleoverflow}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'subscriber', 'subscribers.php?id={moodleoverflow}', '{moodleoverflow}');
+        $rules[] = new restore_log_rule('moodleoverflow', 'subscribers', 'subscribers.php?id={moodleoverflow}', '{moodleoverflow}');
         $rules[] = new restore_log_rule(
             'moodleoverflow',
             'view subscribers',
@@ -205,12 +150,7 @@ public static function define_restore_log_rules() {
             null,
             'delete discussion'
         );
-        $rules[] = new restore_log_rule(
-            'moodleoverflow',
-            'delete discussion',
-            'view.php?id={course_module}',
-            '{moodleoverflow}'
-        );
+        $rules[] = new restore_log_rule('moodleoverflow', 'delete discussion', 'view.php?id={course_module}', '{moodleoverflow}');
         $rules[] = new restore_log_rule(
             'moodleoverflow',
             'add post',
@@ -235,7 +175,6 @@ public static function define_restore_log_rules() {
             'discussion.php?d={moodleoverflow_discussion}',
             '[post]'
         );
-
         return $rules;
     }
 
@@ -250,10 +189,6 @@ public static function define_restore_log_rules() {
      * activity level. All them are rules not linked to any module instance (cmid = 0)
      */
     public static function define_restore_log_rules_for_course() {
-        $rules = [];
-
-        $rules[] = new restore_log_rule('moodleoverflow', 'view all', 'index.php?id={course}', null);
-
-        return $rules;
+        return [new restore_log_rule('moodleoverflow', 'view all', 'index.php?id={course}', null)];
     }
 }