LPD-40838 Simplify test through combining all methods

Author: Stian Sigvartsen

modules/dxp/apps/saml/saml-test/src/testIntegration/java/com/liferay/saml/opensaml/integration/processor/factory/test/UserProcessorFactoryTest.java

@@ -25,7 +25,6 @@
 import java.util.Map;
 
 import org.junit.Assert;
-import org.junit.Before;
 import org.junit.ClassRule;
 import org.junit.Rule;
 import org.junit.Test;
@@ -42,53 +41,34 @@ public class UserProcessorFactoryTest {
 	public static final LiferayIntegrationTestRule liferayIntegrationTestRule =
 		new LiferayIntegrationTestRule();
 
-	@Before
-	public void setUp() throws Exception {
+	@Test
+	public void testUserGroups() throws Exception {
 		_user = UserTestUtil.addUser();
-
 		_userGroup = UserGroupTestUtil.addUserGroup();
 
-		_userGroupLocalService.addUserUserGroup(_user.getUserId(), _userGroup);
-	}
-
-	@Test
-	public void testUserAddsUserGroupsWhenMappedUserGroupComesInTheAssertion()
-		throws Exception {
-
-		User processedUser = _processUser(
+		_user = _processUser(
 			HashMapBuilder.put(
 				"membership:userGroups", new String[] {_userGroup.getName()}
 			).build());
 
 		Assert.assertEquals(
 			1,
-			_userGroupLocalService.getUserUserGroupsCount(
-				processedUser.getUserId()));
-	}
+			_userGroupLocalService.getUserUserGroupsCount(_user.getUserId()));
 
-	@Test
-	public void testUserKeepsUserGroupsWhenMappingIsNotSet() throws Exception {
-		User processedUser = _processUser(Collections.emptyMap());
+		_user = _processUser(Collections.emptyMap());
 
 		Assert.assertEquals(
 			1,
-			_userGroupLocalService.getUserUserGroupsCount(
-				processedUser.getUserId()));
-	}
-
-	@Test
-	public void testUserNotKeepsUserGroupsWhenMappedUserGroupNotComesInTheAssertion()
-		throws Exception {
+			_userGroupLocalService.getUserUserGroupsCount(_user.getUserId()));
 
-		User processedUser = _processUser(
+		_user = _processUser(
 			HashMapBuilder.put(
 				"membership:userGroups", new String[0]
 			).build());
 
 		Assert.assertEquals(
 			0,
-			_userGroupLocalService.getUserUserGroupsCount(
-				processedUser.getUserId()));
+			_userGroupLocalService.getUserUserGroupsCount(_user.getUserId()));
 	}
 
 	private User _processUser(Map<String, String[]> attributesMap)