Skip to content

Commit f105e57

Browse files
authored
refactor: fix failing warnings s3 bucket configuration (#2)
1 parent 8d14612 commit f105e57

File tree

3 files changed

+26
-15
lines changed

3 files changed

+26
-15
lines changed

.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v1.0.0
1+
v1.0.1

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@
2121
| [aws_kms_alias.state](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kms_alias) | resource |
2222
| [aws_kms_key.state](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kms_key) | resource |
2323
| [aws_s3_bucket.bucket](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource |
24+
| [aws_s3_bucket_acl.acl](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource |
2425
| [aws_s3_bucket_public_access_block.bucket-acl](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_public_access_block) | resource |
26+
| [aws_s3_bucket_server_side_encryption_configuration.state_encryption](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_server_side_encryption_configuration) | resource |
27+
| [aws_s3_bucket_versioning.state_versioning](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_versioning) | resource |
2528
## Inputs
2629

2730
| Name | Description | Type | Default | Required |
@@ -43,7 +46,7 @@
4346
### Basic example
4447
```hcl
4548
module "string_ssm_keys" {
46-
source = "[email protected]:masterborn/terraform-kms-tfstate-backend.git?ref=v1.0.0"
49+
source = "[email protected]:masterborn/terraform-kms-tfstate-backend.git?ref=v1.0.1"
4750
bucket_name = "example-state-bucket"
4851
dynamodb_table_name = "example-state-lock"
4952

main.tf

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,27 +24,35 @@ resource "aws_kms_alias" "state" {
2424

2525
resource "aws_s3_bucket" "bucket" {
2626
bucket = var.bucket_name
27+
tags = local.tags
28+
29+
lifecycle {
30+
prevent_destroy = true
31+
}
32+
}
33+
34+
resource "aws_s3_bucket_acl" "acl" {
35+
bucket = aws_s3_bucket.bucket.id
2736
acl = "private"
37+
}
2838

39+
resource "aws_s3_bucket_versioning" "state_versioning" {
40+
bucket = aws_s3_bucket.bucket.id
2941

30-
versioning {
31-
enabled = true
42+
versioning_configuration {
43+
status = "Enabled"
3244
}
45+
}
3346

34-
lifecycle {
35-
prevent_destroy = true
36-
}
47+
resource "aws_s3_bucket_server_side_encryption_configuration" "state_encryption" {
48+
bucket = aws_s3_bucket.bucket.id
3749

38-
server_side_encryption_configuration {
39-
rule {
40-
apply_server_side_encryption_by_default {
41-
kms_master_key_id = aws_kms_key.state.arn
42-
sse_algorithm = "aws:kms"
43-
}
50+
rule {
51+
apply_server_side_encryption_by_default {
52+
kms_master_key_id = aws_kms_key.state.arn
53+
sse_algorithm = "aws:kms"
4454
}
4555
}
46-
47-
tags = local.tags
4856
}
4957

5058
resource "aws_s3_bucket_public_access_block" "bucket-acl" {

0 commit comments

Comments
 (0)