|
1 | | -## Checklist |
| 1 | +### Description |
2 | 2 |
|
3 | | -- Contains unit tests ✅ ❌ |
4 | | -- Contains breaking changes ✅ ❌ |
5 | | -- Contains Atlas changes ✅ ❌ |
6 | | -- Compatible with: MX 7️⃣, 8️⃣, 9️⃣ |
7 | | -- Did you update version and changelog? ✅ ❌ |
8 | | -- PR title properly formatted (`[XX-000]: description`)? ✅ ❌ |
| 3 | +<!--- Describe your changes in detail --> |
9 | 4 |
|
10 | | -#### Web specific |
| 5 | +### Pull request checklist |
11 | 6 |
|
12 | | -- Contains e2e tests ✅ ❌ |
13 | | -- Is accessible ✅ ❌ |
14 | | -- Compatible with Studio ✅ ❌ |
15 | | -- Cross-browser compatible ✅ ❌ |
| 7 | +<!--- Go over all the following points, and put an `x` in all the boxes that apply. --> |
| 8 | +<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> |
16 | 9 |
|
17 | | -#### Native specific |
| 10 | +- [ ] All new and existing tests passed |
| 11 | +- [ ] I run `lint` command locally and it doesn’t give errors |
| 12 | +- [ ] PR title properly formatted `[XX-000]: description` |
| 13 | +- [ ] Added record to packages' CHANGELOG.md |
| 14 | +- [ ] Bumped package version in `package.json` and `package.xml` |
| 15 | +- [ ] Added a link to related project PRs (atlas, pluggable-widgets-tools, testProject, etc.) (optional) |
| 16 | +- [ ] Created docs PR to [mendix/docs](https://github.com/mendix/docs.git) and added a link (optional) |
18 | 17 |
|
19 | | -- Works in Android ✅ ❌ |
20 | | -- Works in iOS ✅ ❌ |
21 | | -- Works in Tablet ✅ ❌ |
| 18 | +### Pull request type |
22 | 19 |
|
23 | | -#### Feature specific |
| 20 | +<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> |
24 | 21 |
|
25 | | -- Comply with designs ✅ ❌ |
26 | | -- Comply with PM's requirements ✅ ❌ |
| 22 | +- [ ] No code changes (changes to documentation, CI, metadata, etc) |
| 23 | +- [ ] Dependency changes (any modification to dependencies in `package.json`) |
| 24 | +- [ ] Bug fix (non-breaking change which fixes an issue) |
| 25 | +- [ ] New feature (non-breaking change which adds functionality) |
| 26 | +- [ ] Breaking change (fix or feature that would cause existing functionality to change) |
| 27 | +- [ ] Test related change (New E2E test, test automation, etc.) |
27 | 28 |
|
28 | | -**_Please remove unnecessary emojis and sections and this comment before proceeding_** |
| 29 | +### What should be covered while testing? |
29 | 30 |
|
30 | | -## This PR contains |
31 | | - |
32 | | -- [ ] Bug fix |
33 | | -- [ ] Feature |
34 | | -- [ ] Refactor |
35 | | -- [ ] Documentation |
36 | | -- [ ] Other (describe) |
37 | | - |
38 | | -## What is the purpose of this PR? |
39 | | - |
40 | | -_..._ |
41 | | - |
42 | | -## Relevant changes |
43 | | - |
44 | | -_Please add a high level explanation of what was changed and how the initial problem was solved_ |
45 | | - |
46 | | -## What should be covered while testing? |
47 | | - |
48 | | -_..._ |
49 | | - |
50 | | -## Extra comments (optional) |
51 | | - |
52 | | -_Please add extra comments or delete the section if not required_ |
| 31 | +<!--- Describe what part of pacakge need to be tested and more important - how --> |
0 commit comments