Skip to content

Commit 46c5087

Browse files
refactor(date-time-picker-web): simplify properties by replacing with system properties
1 parent 335d5d1 commit 46c5087

File tree

2 files changed

+5
-63
lines changed

2 files changed

+5
-63
lines changed

packages/pluggableWidgets/date-time-picker-web/src/DateTimePicker.xml

Lines changed: 4 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -54,46 +54,13 @@
5454
</property>
5555
</propertyGroup>
5656
<propertyGroup caption="Label">
57-
<property key="showLabel" type="boolean" defaultValue="true">
58-
<caption>Show label</caption>
59-
<description />
60-
</property>
61-
<property key="label" type="textTemplate" required="false">
62-
<caption>Label caption</caption>
63-
<description />
64-
</property>
57+
<systemProperty key="Label" />
6558
</propertyGroup>
6659
<propertyGroup caption="Editability">
67-
<property key="editable" type="enumeration" defaultValue="default">
68-
<caption>Editable</caption>
69-
<description />
70-
<enumerationValues>
71-
<enumerationValue key="default">Default</enumerationValue>
72-
<enumerationValue key="never">Never</enumerationValue>
73-
<enumerationValue key="conditionally">Conditionally</enumerationValue>
74-
</enumerationValues>
75-
</property>
76-
<property key="editabilityCondition" type="expression" required="false">
77-
<caption>Condition</caption>
78-
<description />
79-
<returnType type="Boolean" />
80-
</property>
81-
<property key="readOnlyStyle" type="enumeration" defaultValue="default">
82-
<caption>Read-only style</caption>
83-
<description />
84-
<enumerationValues>
85-
<enumerationValue key="default">Based on data view (Control)</enumerationValue>
86-
<enumerationValue key="control">Control</enumerationValue>
87-
<enumerationValue key="text">Text</enumerationValue>
88-
</enumerationValues>
89-
</property>
60+
<systemProperty key="Editability" />
9061
</propertyGroup>
91-
<propertyGroup caption="Visibility">
92-
<property key="visible" type="expression" required="false">
93-
<caption>Visible</caption>
94-
<description />
95-
<returnType type="Boolean" />
96-
</property>
62+
<propertyGroup caption="Conditional visibility">
63+
<systemProperty key="Visibility" />
9764
</propertyGroup>
9865
<propertyGroup caption="Validation">
9966
<property key="validationType" type="enumeration" defaultValue="none">

packages/pluggableWidgets/date-time-picker-web/typings/DateTimePickerProps.d.ts

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3,35 +3,23 @@
33
* WARNING: All changes made to this file will be overwritten
44
* @author Mendix Widgets Framework Team
55
*/
6-
import { CSSProperties } from "react";
76
import { ActionValue, DynamicValue, EditableValue } from "mendix";
87

98
export type TypeEnum = "date" | "time" | "range" | "datetime";
109

11-
export type EditableEnum = "default" | "never" | "conditionally";
12-
13-
export type ReadOnlyStyleEnum = "default" | "control" | "text";
14-
1510
export type ValidationTypeEnum = "none" | "required" | "custom";
1611

1712
export interface DateTimePickerContainerProps {
1813
name: string;
19-
class: string;
20-
style?: CSSProperties;
2114
tabIndex?: number;
15+
id: string;
2216
type: TypeEnum;
2317
dateFormat: string;
2418
timeFormat: string;
2519
dateTimeFormat: string;
2620
placeholder?: DynamicValue<string>;
2721
dateAttribute: EditableValue<Date>;
2822
endDateAttribute?: EditableValue<Date>;
29-
showLabel: boolean;
30-
label?: DynamicValue<string>;
31-
editable: EditableEnum;
32-
editabilityCondition?: DynamicValue<boolean>;
33-
readOnlyStyle: ReadOnlyStyleEnum;
34-
visible?: DynamicValue<boolean>;
3523
validationType: ValidationTypeEnum;
3624
customValidation?: DynamicValue<boolean>;
3725
validationMessage?: DynamicValue<string>;
@@ -42,13 +30,6 @@ export interface DateTimePickerContainerProps {
4230
}
4331

4432
export interface DateTimePickerPreviewProps {
45-
/**
46-
* @deprecated Deprecated since version 9.18.0. Please use class property instead.
47-
*/
48-
className: string;
49-
class: string;
50-
style: string;
51-
styleObject?: CSSProperties;
5233
readOnly: boolean;
5334
renderMode: "design" | "xray" | "structure";
5435
translate: (text: string) => string;
@@ -59,12 +40,6 @@ export interface DateTimePickerPreviewProps {
5940
placeholder: string;
6041
dateAttribute: string;
6142
endDateAttribute: string;
62-
showLabel: boolean;
63-
label: string;
64-
editable: EditableEnum;
65-
editabilityCondition: string;
66-
readOnlyStyle: ReadOnlyStyleEnum;
67-
visible: string;
6843
validationType: ValidationTypeEnum;
6944
customValidation: string;
7045
validationMessage: string;

0 commit comments

Comments
 (0)