Skip to content

Commit 7bfe7eb

Browse files
committed
feat(gallery-web): always show header, change texts
1 parent 0d64560 commit 7bfe7eb

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

packages/pluggableWidgets/gallery-web/src/Gallery.editorConfig.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ export function getProperties(
2626
hidePropertyIn(defaultProperties, values, "emptyPlaceholder");
2727
}
2828

29-
if (!showHeader(values)) {
30-
hidePropertyIn(defaultProperties, values, "filtersPlaceholder");
31-
}
32-
3329
if (values.itemSelection === "None") {
3430
hidePropertyIn(defaultProperties, values, "onSelectionChange");
3531
}
@@ -116,7 +112,7 @@ export function getPreview(values: GalleryPreviewProps, isDarkMode: boolean): St
116112
{
117113
type: "DropZone",
118114
property: values.filtersPlaceholder,
119-
placeholder: "Gallery header: Place widgets here"
115+
placeholder: "Place widgets like filter widget(s) and action button(s) here"
120116
} as DropZoneProps
121117
]
122118
} as RowLayoutProps;
@@ -187,14 +183,10 @@ export function getPreview(values: GalleryPreviewProps, isDarkMode: boolean): St
187183

188184
return {
189185
type: "Container",
190-
children: [titleHeader, ...(showHeader(values) ? [filters] : []), content, ...footer]
186+
children: [titleHeader, filters, content, ...footer]
191187
};
192188
}
193189

194190
function getSingularPlural(word: string, elements: number): string {
195191
return elements > 1 ? word + "s" : word;
196192
}
197-
198-
function showHeader(values: GalleryPreviewProps): boolean {
199-
return values.filterList?.length > 0 || values.sortList?.length > 0 || values.itemSelection === "Multi";
200-
}

packages/pluggableWidgets/gallery-web/src/Gallery.editorPreview.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ function Preview(props: GalleryPreviewProps): ReactElement {
88
id: String(index) as GUID
99
}));
1010

11-
const showHeader = props.filterList.length > 0 || props.sortList.length > 0 || props.itemSelection === "Multi";
1211
return (
1312
<GalleryComponent
1413
className={props.class}
@@ -22,13 +21,11 @@ function Preview(props: GalleryPreviewProps): ReactElement {
2221
[props.emptyPlaceholder]
2322
)}
2423
header={
25-
showHeader ? (
26-
<props.filtersPlaceholder.renderer caption="Gallery header: Place widgets here">
27-
<div />
28-
</props.filtersPlaceholder.renderer>
29-
) : null
24+
<props.filtersPlaceholder.renderer caption="Place widgets like filter widget(s) and action button(s) here">
25+
<div />
26+
</props.filtersPlaceholder.renderer>
3027
}
31-
showHeader={!!props.filterList.length}
28+
showHeader
3229
hasMoreItems={false}
3330
items={items}
3431
itemRenderer={useCallback(

0 commit comments

Comments
 (0)