Skip to content

Commit a77ee6e

Browse files
yordan-stgjulivan
authored andcommitted
chore: update changelog
1 parent 603a6ad commit a77ee6e

File tree

13 files changed

+22
-39
lines changed

13 files changed

+22
-39
lines changed

packages/pluggableWidgets/combobox-web/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
1717

1818
### Added
1919

20-
- We added a configurable debounce interval for datasource filter operations via a new property in the Advanced tab.
20+
- We enabled a configurable debounce interval for datasource filter operations as well, via a existing property filterInputDebounceInterval.
2121

2222
## [2.5.0] - 2025-08-12
2323

packages/pluggableWidgets/combobox-web/src/Combobox.editorConfig.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ export function getProperties(
152152
"selectionMethod",
153153
"selectAllButton",
154154
"selectAllButtonCaption",
155-
"datasourceFilterDebounceInterval",
156155
...ASSOCIATION_SOURCE_CONFIG,
157156
...DATABASE_SOURCE_CONFIG,
158157
...LAZY_LOADING_CONFIG
@@ -179,10 +178,6 @@ export function getProperties(
179178
hidePropertiesIn(defaultProperties, values, ["loadingType"]);
180179
}
181180

182-
if (values.onChangeFilterInputEvent === null) {
183-
hidePropertiesIn(defaultProperties, values, ["filterInputDebounceInterval"]);
184-
}
185-
186181
return defaultProperties;
187182
}
188183

packages/pluggableWidgets/combobox-web/src/Combobox.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@
329329
<caption>On leave</caption>
330330
<description />
331331
</property>
332-
333332
<property key="onChangeFilterInputEvent" type="action" required="false">
334333
<caption>On filter input change</caption>
335334
<description />
@@ -417,10 +416,6 @@
417416
<enumerationValue key="skeleton">Skeleton</enumerationValue>
418417
</enumerationValues>
419418
</property>
420-
<property key="datasourceFilterDebounceInterval" type="integer" required="true" defaultValue="200">
421-
<caption>Filter debounce</caption>
422-
<description>Debounce interval in milliseconds.</description>
423-
</property>
424419
</propertyGroup>
425420
<propertyGroup caption="Multiple-selection">
426421
<property key="selectedItemsSorting" type="enumeration" defaultValue="none" required="true">

packages/pluggableWidgets/combobox-web/src/__tests__/MultiSelection.spec.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ describe("Combo box (Association)", () => {
7777
selectedItemsSorting: "none",
7878
customEditability: "default",
7979
customEditabilityExpression: dynamic(false),
80-
filterInputDebounceInterval: 200,
81-
datasourceFilterDebounceInterval: 200
80+
filterInputDebounceInterval: 200
8281
};
8382
if (defaultProps.optionsSourceAssociationCaptionType === "expression") {
8483
defaultProps.optionsSourceAssociationCaptionExpression!.get = i => dynamic(`${i.id}`);

packages/pluggableWidgets/combobox-web/src/__tests__/SingleSelection.spec.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ describe("Combo box (Association)", () => {
8080
selectedItemsSorting: "none",
8181
customEditability: "default",
8282
customEditabilityExpression: dynamic(false),
83-
filterInputDebounceInterval: 200,
84-
datasourceFilterDebounceInterval: 200
83+
filterInputDebounceInterval: 200
8584
};
8685
if (defaultProps.optionsSourceAssociationCaptionType === "expression") {
8786
defaultProps.optionsSourceAssociationCaptionExpression!.get = i => dynamic(`${i.id}`);

packages/pluggableWidgets/combobox-web/src/__tests__/StaticSelection.spec.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ describe("Combo box (Static values)", () => {
7878
selectedItemsSorting: "none",
7979
customEditability: "default",
8080
customEditabilityExpression: dynamic(false),
81-
filterInputDebounceInterval: 200,
82-
datasourceFilterDebounceInterval: 200
81+
filterInputDebounceInterval: 200
8382
};
8483
if (defaultProps.optionsSourceAssociationCaptionType === "expression") {
8584
defaultProps.optionsSourceAssociationCaptionExpression!.get = i => dynamic(`${i.id}`);

packages/pluggableWidgets/combobox-web/src/helpers/Association/BaseAssociationSelector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export class BaseAssociationSelector<T extends string | string[], R extends Refe
4646
customContentType,
4747
lazyLoading,
4848
loadingType,
49-
datasourceFilterDebounceInterval
49+
filterInputDebounceInterval
5050
] = extractAssociationProps(props);
5151

5252
this.lazyLoader.updateProps(ds);
@@ -66,7 +66,7 @@ export class BaseAssociationSelector<T extends string | string[], R extends Refe
6666
filterType,
6767
lazyLoading,
6868
attributeId: captionType === "attribute" ? (captionProvider as ListAttributeValue<string>).id : undefined,
69-
datasourceFilterDebounceInterval
69+
filterInputDebounceInterval
7070
});
7171

7272
if (

packages/pluggableWidgets/combobox-web/src/helpers/Association/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export function extractAssociationProps(props: ComboboxContainerProps): Extracti
3636
const attr = props.attributeAssociation;
3737
const filterType = props.filterType;
3838
const onChangeEvent = props.onChangeEvent;
39-
const datasourceFilterDebounceInterval = props.datasourceFilterDebounceInterval;
39+
const filterInputDebounceInterval = props.filterInputDebounceInterval;
4040

4141
if (!attr) {
4242
throw new Error("'optionsSourceType' type is 'association' but 'attributeAssociation' is not defined.");
@@ -82,6 +82,6 @@ export function extractAssociationProps(props: ComboboxContainerProps): Extracti
8282
customContentType,
8383
lazyLoading,
8484
loadingType,
85-
datasourceFilterDebounceInterval
85+
filterInputDebounceInterval
8686
];
8787
}

packages/pluggableWidgets/combobox-web/src/helpers/BaseDatasourceOptionsProvider.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export interface BaseProps {
1111
ds: ListValue;
1212
filterType: FilterTypeEnum;
1313
lazyLoading: boolean;
14-
datasourceFilterDebounceInterval?: number;
14+
filterInputDebounceInterval?: number;
1515
}
1616

1717
export class BaseDatasourceOptionsProvider extends BaseOptionsProvider<ObjectItem, BaseProps> {
@@ -20,7 +20,7 @@ export class BaseDatasourceOptionsProvider extends BaseOptionsProvider<ObjectIte
2020
protected loading: boolean = false;
2121
private debouncedSetFilter?: (filterCondition: any) => void;
2222
private abortDebouncedFilter?: () => void;
23-
private datasourceFilterDebounceInterval: number = 200;
23+
private filterInputDebounceInterval: number = 200;
2424

2525
constructor(
2626
caption: CaptionsProvider,
@@ -30,13 +30,11 @@ export class BaseDatasourceOptionsProvider extends BaseOptionsProvider<ObjectIte
3030
}
3131

3232
private createDebouncedSetFilter(): void {
33-
if (this.abortDebouncedFilter) {
34-
this.abortDebouncedFilter();
35-
}
33+
this.cleanup();
3634

3735
const [debouncedFn, abort] = debounce((filterCondition: any) => {
3836
this.ds?.setFilter(filterCondition);
39-
}, this.datasourceFilterDebounceInterval);
37+
}, this.filterInputDebounceInterval);
4038

4139
this.debouncedSetFilter = debouncedFn;
4240
this.abortDebouncedFilter = abort;
@@ -125,9 +123,9 @@ export class BaseDatasourceOptionsProvider extends BaseOptionsProvider<ObjectIte
125123
this.filterType = props.filterType;
126124
this.lazyLoading = props.lazyLoading;
127125

128-
const newInterval = props.datasourceFilterDebounceInterval ?? 200;
129-
if (newInterval !== this.datasourceFilterDebounceInterval) {
130-
this.datasourceFilterDebounceInterval = newInterval;
126+
const newInterval = props.filterInputDebounceInterval ?? 200;
127+
if (newInterval !== this.filterInputDebounceInterval) {
128+
this.filterInputDebounceInterval = newInterval;
131129
this.createDebouncedSetFilter();
132130
}
133131

packages/pluggableWidgets/combobox-web/src/helpers/Database/DatabaseMultiSelectionSelector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export class DatabaseMultiSelectionSelector implements MultiSelector {
7676
lazyLoading,
7777
loadingType,
7878
valueSourceAttribute,
79-
datasourceFilterDebounceInterval
79+
filterInputDebounceInterval
8080
} = extractDatabaseProps(props);
8181

8282
if (
@@ -109,7 +109,7 @@ export class DatabaseMultiSelectionSelector implements MultiSelector {
109109
filterType,
110110
lazyLoading,
111111
attributeId: captionType === "attribute" ? (captionProvider as ListAttributeValue<string>).id : undefined,
112-
datasourceFilterDebounceInterval
112+
filterInputDebounceInterval
113113
});
114114

115115
if (this.selectionMethod === "rowclick" || this.customContentType === "yes") {

0 commit comments

Comments
 (0)