feat(html-element-web): make data source required

As suggested by PAG team, instead of using custom require-ness check on data source,
make data source required, when data source is hidden in props, this effectively
works as it is not required, no checks run on it.

Author: r0b1n

packages/pluggableWidgets/html-element-web/src/HTMLElement.editorConfig.ts

@@ -141,47 +141,38 @@ export function check(values: HTMLElementPreviewProps): Problem[] {
         }
     }
 
-    if (values.tagUseRepeat && values.tagContentRepeatDataSource === null) {
-        // make date source required if set to repeat
-        errors.push({
-            severity: "error",
-            property: "tagContentRepeatDataSource",
-            message: "Property 'Data source' is required."
-        });
-    } else {
-        const existingAttributeNames = new Set();
-        values.attributes.forEach((attr, i) => {
-            if (existingAttributeNames.has(attr.attributeName)) {
-                errors.push({
-                    severity: "error",
-                    property: `attributes/${i + 1}/attributeName`,
-                    message: `Attribute with name '${attr.attributeName}' already exists.`
-                });
-            }
-            existingAttributeNames.add(attr.attributeName);
-
-            const attributePropName = attributeValuePropNameFor(values, attr.attributeValueType);
-            if (!attr[attributePropName].length) {
-                errors.push({
-                    severity: "warning",
-                    property: `attributes/${i + 1}/${attributePropName}`,
-                    message: `Value is not specified for attribute '${attr.attributeName}'.`
-                });
-            }
-        });
-
-        const existingEventNames = new Set();
-        values.events.forEach((attr, i) => {
-            if (existingEventNames.has(attr.eventName)) {
-                errors.push({
-                    severity: "error",
-                    property: `attributes/${i + 1}/eventName`,
-                    message: `Event with name '${attr.eventName}' already exists.`
-                });
-            }
-            existingEventNames.add(attr.eventName);
-        });
-    }
+    const existingAttributeNames = new Set();
+    values.attributes.forEach((attr, i) => {
+        if (existingAttributeNames.has(attr.attributeName)) {
+            errors.push({
+                severity: "error",
+                property: `attributes/${i + 1}/attributeName`,
+                message: `Attribute with name '${attr.attributeName}' already exists.`
+            });
+        }
+        existingAttributeNames.add(attr.attributeName);
+
+        const attributePropName = attributeValuePropNameFor(values, attr.attributeValueType);
+        if (!attr[attributePropName].length) {
+            errors.push({
+                severity: "warning",
+                property: `attributes/${i + 1}/${attributePropName}`,
+                message: `Value is not specified for attribute '${attr.attributeName}'.`
+            });
+        }
+    });
+
+    const existingEventNames = new Set();
+    values.events.forEach((attr, i) => {
+        if (existingEventNames.has(attr.eventName)) {
+            errors.push({
+                severity: "error",
+                property: `attributes/${i + 1}/eventName`,
+                message: `Event with name '${attr.eventName}' already exists.`
+            });
+        }
+        existingEventNames.add(attr.eventName);
+    });
 
     return errors;
 }

packages/pluggableWidgets/html-element-web/src/HTMLElement.xml

@@ -82,7 +82,7 @@
                 </property>
 
                 <!-- Data source for repeating content -->
-                <property key="tagContentRepeatDataSource" type="datasource" required="false" isList="true">
+                <property key="tagContentRepeatDataSource" type="datasource" required="true" isList="true">
                     <caption>Data source</caption>
                     <description />
                 </property>

packages/pluggableWidgets/html-element-web/typings/HTMLElementProps.d.ts

@@ -57,7 +57,7 @@ export interface HTMLElementContainerProps {
     tagNameCustom: string;
     attributes: AttributesType[];
     tagUseRepeat: boolean;
-    tagContentRepeatDataSource?: ListValue;
+    tagContentRepeatDataSource: ListValue;
     tagContentMode: TagContentModeEnum;
     tagContentHTML?: DynamicValue<string>;
     tagContentContainer?: ReactNode;