Remove enzyme commands

alihcsumer · alihcsumer · commit 5c6c594d96df · 2025-12-04T15:45:45.000+01:00
diff --git a/packages/generator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-js-unit-e2e.json b/packages/generator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-js-unit-e2e.json
@@ -21,8 +21,8 @@
     "build": "pluggable-widgets-tools build:web",
     "lint": "pluggable-widgets-tools lint",
     "lint:fix": "pluggable-widgets-tools lint:fix",
-    "test": "pluggable-widgets-tools test:unit:web:enzyme-free && npm run test:e2e",
-    "test:unit": "pluggable-widgets-tools test:unit:web:enzyme-free",
+    "test": "pluggable-widgets-tools test:unit:web && npm run test:e2e",
+    "test:unit": "pluggable-widgets-tools test:unit:web",
     "test:e2e": "npx cypress open --browser chrome --e2e",
     "prerelease": "npm run lint",
     "release": "pluggable-widgets-tools release:web"
diff --git a/packages/generator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-js-unit.json b/packages/generator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-js-unit.json
@@ -21,8 +21,8 @@
     "build": "pluggable-widgets-tools build:web",
     "lint": "pluggable-widgets-tools lint",
     "lint:fix": "pluggable-widgets-tools lint:fix",
-    "test": "pluggable-widgets-tools test:unit:web:enzyme-free",
-    "test:unit": "pluggable-widgets-tools test:unit:web:enzyme-free",
+    "test": "pluggable-widgets-tools test:unit:web",
+    "test:unit": "pluggable-widgets-tools test:unit:web",
     "prerelease": "npm run lint",
     "release": "pluggable-widgets-tools release:web"
   },
diff --git a/packages/generator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-ts-unit-e2e.json b/packages/generator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-ts-unit-e2e.json
@@ -21,8 +21,8 @@
     "build": "pluggable-widgets-tools build:web",
     "lint": "pluggable-widgets-tools lint",
     "lint:fix": "pluggable-widgets-tools lint:fix",
-    "test": "pluggable-widgets-tools test:unit:web:enzyme-free && npm run test:e2e",
-    "test:unit": "pluggable-widgets-tools test:unit:web:enzyme-free",
+    "test": "pluggable-widgets-tools test:unit:web && npm run test:e2e",
+    "test:unit": "pluggable-widgets-tools test:unit:web",
     "test:e2e": "npx cypress open --browser chrome --e2e",
     "prerelease": "npm run lint",
     "release": "pluggable-widgets-tools release:web"
diff --git a/packages/generator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-ts-unit.json b/packages/generator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-ts-unit.json
@@ -21,8 +21,8 @@
     "build": "pluggable-widgets-tools build:web",
     "lint": "pluggable-widgets-tools lint",
     "lint:fix": "pluggable-widgets-tools lint:fix",
-    "test": "pluggable-widgets-tools test:unit:web:enzyme-free",
-    "test:unit": "pluggable-widgets-tools test:unit:web:enzyme-free",
+    "test": "pluggable-widgets-tools test:unit:web",
+    "test:unit": "pluggable-widgets-tools test:unit:web",
     "prerelease": "npm run lint",
     "release": "pluggable-widgets-tools release:web"
   },
diff --git a/packages/generator-widget/generators/app/templates/packages/package_web.json.ejs b/packages/generator-widget/generators/app/templates/packages/package_web.json.ejs
@@ -21,8 +21,8 @@
     "build": "pluggable-widgets-tools build:web",
     "lint": "pluggable-widgets-tools lint",
     "lint:fix": "pluggable-widgets-tools lint:fix",<% if (hasUnitTests) { %>
-    "test": "pluggable-widgets-tools test:unit:web:enzyme-free<% if (hasE2eTests) { %> && npm run test:e2e<% } %>",
-    "test:unit": "pluggable-widgets-tools test:unit:web:enzyme-free",<% } %><% if (hasE2eTests) { %>
+    "test": "pluggable-widgets-tools test:unit:web<% if (hasE2eTests) { %> && npm run test:e2e<% } %>",
+    "test:unit": "pluggable-widgets-tools test:unit:web",<% } %><% if (hasE2eTests) { %>
     "test:e2e": "npx cypress open --browser chrome --e2e",<% } %>
     "prerelease": "npm run lint",
     "release": "pluggable-widgets-tools release:web"
diff --git a/packages/pluggable-widgets-tools/bin/mx-scripts.js b/packages/pluggable-widgets-tools/bin/mx-scripts.js
@@ -3,6 +3,7 @@ const { execSync, spawnSync } = require("child_process");
 const { existsSync } = require("fs");
 const { delimiter, dirname, join, parse } = require("path");
 const { checkMigration } = require("../utils/migration");
+const { checkForEnzymeUsage } = require("../utils/enzyme-detector");
 const { red } = require("ansi-colors");
 
 checkNodeVersion();
@@ -21,6 +22,11 @@ checkNodeVersion();
     if (args.indexOf("--subprojectPath") > -1) {
         args.splice(args.indexOf("--subprojectPath"), 2);
     }
+    
+    if (cmd && cmd.startsWith("test:unit")) {
+        checkForEnzymeUsage();
+    }
+    
     const realCommand = getRealCommand(cmd, toolsRoot) + " " + args.join(" ");
     console.log(`Running MX Widgets Tools script ${cmd}...`);
 
@@ -90,8 +96,6 @@ function getRealCommand(cmd, toolsRoot) {
             return `jest --projects "${join(toolsRoot, "test-config/jest.config.js")}"`;
         case "test:unit:native":
             return `jest --projects "${join(toolsRoot, "test-config/jest.native.config.js")}"`;
-        case "test:unit:web:enzyme-free":
-            return `jest --projects "${join(toolsRoot, "test-config/jest.enzyme-free.config.js")}"`;
         case "test:e2e":
         case "test:e2e:ts":
         case "test:e2e:web:cypress":
diff --git a/packages/pluggable-widgets-tools/package.json b/packages/pluggable-widgets-tools/package.json
@@ -32,7 +32,6 @@
     "@babel/preset-env": "^7.26.0",
     "@babel/preset-react": "^7.25.9",
     "@react-native/babel-preset": "0.77.3",
-    "@cfaester/enzyme-adapter-react-18": "^0.6.0",
     "@prettier/plugin-xml": "^1.2.0",
     "@rollup/plugin-alias": "^5.1.1",
     "@rollup/plugin-babel": "^6.0.4",
@@ -61,8 +60,6 @@
     "concurrently": "^6.0.0",
     "core-js": "^3.6.5",
     "dotenv": "^8.2.0",
-    "enzyme": "^3.11.0",
-    "enzyme-to-json": "^3.6.1",
     "eslint": "^7.20.0",
     "eslint-config-prettier": "^8.0.0",
     "eslint-plugin-jest": "^24.1.5",
@@ -80,7 +77,6 @@
     "jest-environment-jsdom": "^29.4.1",
     "jest-jasmine2": "^29.0.3",
     "jest-junit": "^13.0.0",
-    "jest-react-hooks-shallow": "^1.5.1",
     "make-dir": "^3.1.0",
     "mendix": "^10.21.64362",
     "mime": "^3.0.0",
diff --git a/packages/pluggable-widgets-tools/test-config/jest.config.js b/packages/pluggable-widgets-tools/test-config/jest.config.js
@@ -7,7 +7,6 @@ module.exports = {
     testRunner: "jest-jasmine2",
     rootDir: join(projectDir, "src"),
     setupFilesAfterEnv: [join(__dirname, "test-index.js")],
-    snapshotSerializers: ["enzyme-to-json/serializer"],
     testMatch: ["<rootDir>/**/*.spec.{js,jsx,ts,tsx}"],
     transform: {
         "^.+\\.tsx?$": [
diff --git a/packages/pluggable-widgets-tools/test-config/jest.enzyme-free.config.js b/packages/pluggable-widgets-tools/test-config/jest.enzyme-free.config.js
diff --git a/packages/pluggable-widgets-tools/test-config/test-index-native.js b/packages/pluggable-widgets-tools/test-config/test-index-native.js
@@ -1,5 +1,4 @@
 const { TextEncoder, TextDecoder } = require("util");
-const enableHooks = require("jest-react-hooks-shallow").default;
 
 Object.defineProperties(global, {
     TextEncoder: {
@@ -10,7 +9,6 @@ Object.defineProperties(global, {
     }
 });
 
-enableHooks(jest);
 global.setImmediate = global.setTimeout;
 
 const origConsole = console.error;
diff --git a/packages/pluggable-widgets-tools/test-config/test-index-no-enzyme.js b/packages/pluggable-widgets-tools/test-config/test-index-no-enzyme.js
diff --git a/packages/pluggable-widgets-tools/test-config/test-index.js b/packages/pluggable-widgets-tools/test-config/test-index.js
@@ -1,8 +1,5 @@
 require("@testing-library/jest-dom");
 const { TextEncoder, TextDecoder } = require("util");
-const { configure: configureEnzyme } = require("enzyme");
-const Adapter = require("@cfaester/enzyme-adapter-react-18").default;
-const enableHooks = require("jest-react-hooks-shallow").default;
 
 Object.defineProperties(global, {
     TextEncoder: {
@@ -12,7 +9,3 @@ Object.defineProperties(global, {
         value: TextDecoder
     }
 });
-
-configureEnzyme({ adapter: new Adapter() });
-enableHooks(jest);
-global.setImmediate = global.setTimeout;
diff --git a/packages/pluggable-widgets-tools/utils/enzyme-detector.js b/packages/pluggable-widgets-tools/utils/enzyme-detector.js
@@ -0,0 +1,68 @@
+const { existsSync, readdirSync, readFileSync, statSync } = require("fs");
+const { join } = require("path");
+const { yellow } = require("ansi-colors");
+
+function checkForEnzymeUsage(srcDir = "src") {
+    const projectRoot = process.cwd();
+    const srcPath = join(projectRoot, srcDir);
+
+    if (!existsSync(srcPath)) {
+        return;
+    }
+
+    const enzymeFiles = [];
+
+    function scanDirectory(dir) {
+        try {
+            const entries = readdirSync(dir);
+            for (const entry of entries) {
+                const fullPath = join(dir, entry);
+                const stat = statSync(fullPath);
+
+                if (stat.isDirectory()) {
+                    scanDirectory(fullPath);
+                } else if (
+                    stat.isFile() &&
+                    (entry.endsWith(".js") ||
+                        entry.endsWith(".jsx") ||
+                        entry.endsWith(".ts") ||
+                        entry.endsWith(".tsx"))
+                ) {
+                    const content = readFileSync(fullPath, "utf8");
+                    // Check for enzyme imports or requires
+                    if (
+                        /from\s+['"]enzyme['"]/.test(content) ||
+                        /require\s*\(\s*['"]enzyme['"]\s*\)/.test(content) ||
+                        /import\s+.*\s+from\s+['"]enzyme['"]/.test(content) ||
+                        /shallow|mount|render/.test(content) && /enzyme/.test(content)
+                    ) {
+                        enzymeFiles.push(fullPath.replace(projectRoot, "."));
+                    }
+                }
+            }
+        } catch (error) {
+
+        }
+    }
+
+    scanDirectory(srcPath);
+
+    if (enzymeFiles.length > 0) {
+        console.log(yellow("\n WARNING: Enzyme usage detected in your tests"));
+        console.log(
+            yellow(
+                "Enzyme is no longer supported. Please migrate your tests to React Testing Library."
+            )
+        );
+        console.log(yellow("\nFiles with potential Enzyme usage:"));
+        enzymeFiles.forEach(file => console.log(yellow(` ${file}`)));
+        console.log(
+            yellow(
+                "\nFor migration guidance, see: https://testing-library.com/docs/react-testing-library/migrate-from-enzyme"
+            )
+        );
+        console.log();
+    }
+}
+
+module.exports = { checkForEnzymeUsage };
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
