7022: Fix parser error when service IDs start with edge direction letters (L, R, T, B) #7106
Conversation
π¦ Changeset detectedLatest commit: 5e74f76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
β Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7106 +/- ##
==========================================
- Coverage 3.55% 3.55% -0.01%
==========================================
Files 473 474 +1
Lines 47496 47507 +11
Branches 730 730
==========================================
Hits 1687 1687
- Misses 45809 45820 +11
Flags with carried forward coverage won't be shown. Click here to find out more. π New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications βοΈ
|
darshanr0107
changed the title
| lhsId=ID lhsGroup?=ARROW_GROUP? Arrow rhsId=ID rhsGroup?=ARROW_GROUP? EOL | ||
| ; | ||
|
|
||
| terminal ARROW_DIRECTION: 'L' | 'R' | 'T' | 'B'; |
There was a problem hiding this comment.
Isn't this removing the ARROW_DIRECTION feature then? Is that not being used?
Was it undocumented?
There was a problem hiding this comment.
TheARROW_DIRECTIONfeature is still supported. The terminal was removed to fix parsing conflicts with IDs starting with L/R/T/B. Directions are now parsed as IDs and validated downstream(in DB layer)
There was a problem hiding this comment.
I don't see any code related to DB in this PR π€
Also, rhsDir=ID ':' now rhsDir is ID, so not a direction at all, so shouldn't we fix the jison as well?
There was a problem hiding this comment.
I don't see any code related to DB in this PR π€ Also,
rhsDir=ID ':'now rhsDir is ID, so not a direction at all, so shouldn't we fix the jison as well?
The DB validations were already in place , rhsDir suggests it should be a direction, it's still semantically correct - it will be a direction after validation
β¦fix-edge-direction-id-parsing
π Summary
This PR fixes an issue where architecture diagram parsing fails when an ID starts with one of the edge direction letters β L, R, T, or B.
Resolves #7022
π Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
π Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.