Skip to content

Commit 50f85f1

Browse files
committed
Docs.
1 parent f819b10 commit 50f85f1

File tree

9 files changed

+18
-7
lines changed

9 files changed

+18
-7
lines changed

packages/dds/shared-object-base/src/sharedObjectKernel.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,9 @@ export interface KernelArgs {
294294
*/
295295
readonly lastSequenceNumber: () => number;
296296
/**
297-
* The minVersionForCollab specified when instantiating the ContainerRuntime.
297+
* The minVersionForCollab specified when instantiating the ContainerRuntime. Passed to the SharedKernelFactory so that a
298+
* compatible set of feature flags and formats can be enabled in the SharedObject implementation.
299+
* See {@link @fluidframework/container-runtime#LoadContainerRuntimeParams} for more details on this property.
298300
*/
299301
readonly minVersionForCollab: MinimumVersionForCollab | undefined;
300302
}

packages/runtime/container-runtime/src/channelCollection.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@ export interface IFluidParentContextPrivate extends Omit<IFluidParentContext, "i
132132
readonly isReadOnly: () => boolean;
133133

134134
/**
135-
* Gets the minVersionForCollab passed into the ContainerRuntime.
135+
* Gets the minVersionForCollab passed into the ContainerRuntime. Consumed by {@link FluidDataStoreContext}.
136+
* See {@link @fluidframework/container-runtime#LoadContainerRuntimeParams} for more details.
136137
*/
137138
getMinVersionForCollab(): MinimumVersionForCollab;
138139
}

packages/runtime/container-runtime/src/dataStoreContext.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,6 +1216,9 @@ export abstract class FluidDataStoreContext
12161216
return this.parentContext.uploadBlob(blob, signal);
12171217
}
12181218

1219+
/**
1220+
* {@inheritdoc IFluidDataStoreContext.getMinVersionForCollab}
1221+
*/
12191222
public getMinVersionForCollab(): MinimumVersionForCollab {
12201223
return this.parentContext.getMinVersionForCollab();
12211224
}

packages/runtime/datastore-definitions/src/dataStoreRuntime.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,10 @@ export interface IFluidDataStoreRuntimeInternalConfig {
197197
readonly submitMessagesWithoutEncodingHandles?: boolean;
198198

199199
/**
200-
* The minVersionForCollab used when instantiating the ContainerRuntime. DDSes may read this value to determine which feature flags should be enabled.
200+
* The minVersionForCollab used when instantiating the ContainerRuntime. DDSes may read this value to determine which feature flags
201+
* should be enabled. This property is consumed by SharedObjectFactory (which are implementations of
202+
* {@link @fluidframework/datastore-definitions#IChannelFactory}).
203+
* See {@link @fluidframework/container-runtime#LoadContainerRuntimeParams} for more details on `minVersionForCollab`.
201204
*/
202205
readonly minVersionForCollab?: MinimumVersionForCollab | undefined;
203206
}

packages/runtime/datastore/api-report/datastore.legacy.beta.api.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ export class FluidDataStoreRuntime extends TypedEventEmitter<IFluidDataStoreRunt
6868
// (undocumented)
6969
get logger(): ITelemetryLoggerExt;
7070
makeVisibleAndAttachGraph(): void;
71-
// (undocumented)
7271
readonly minVersionForCollab: MinimumVersionForCollab | undefined;
7372
notifyReadOnlyState(readonly: boolean): void;
7473
// (undocumented)

packages/runtime/datastore/src/dataStoreRuntime.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ export class FluidDataStoreRuntime
294294
private readonly submitMessagesWithoutEncodingHandles: boolean;
295295

296296
/**
297-
* @see IFluidDataStoreRuntimeInternalConfig.minVersionForCollab
297+
* See `IFluidDataStoreRuntimeInternalConfig.minVersionForCollab`.
298298
*/
299299
public readonly minVersionForCollab: MinimumVersionForCollab | undefined;
300300

packages/runtime/runtime-definitions/src/dataStoreContext.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -740,7 +740,8 @@ export interface IFluidDataStoreContext extends IFluidParentContext {
740740
): ReturnType<Exclude<T["createDataStore"], undefined>>;
741741

742742
/**
743-
* Gets the minVersionForCollab passed into the ContainerRuntime.
743+
* Gets the minVersionForCollab passed into the ContainerRuntime. Consumed by {@link @fluidframework/datastore#FluidDataStoreRuntime}.
744+
* See {@link @fluidframework/container-runtime#LoadContainerRuntimeParams} for more details.
744745
*/
745746
getMinVersionForCollab?(): MinimumVersionForCollab;
746747
}

packages/runtime/test-runtime-utils/api-report/test-runtime-utils.legacy.beta.api.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@ export class MockFluidDataStoreContext implements IFluidDataStoreContext {
350350
isLocalDataStore: boolean;
351351
// (undocumented)
352352
makeLocallyVisible(): void;
353-
// (undocumented)
354353
minVersionForCollab: MinimumVersionForCollab;
355354
// (undocumented)
356355
off(event: string | symbol, listener: (...args: any[]) => void): this;

packages/runtime/test-runtime-utils/src/mocksDataStoreContext.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,9 @@ export class MockFluidDataStoreContext implements IFluidDataStoreContext {
7777
public createProps?: any;
7878
public scope: FluidObject = undefined as any;
7979

80+
/**
81+
* Allows tests to set the value of minVersionForCollab.
82+
*/
8083
public minVersionForCollab: MinimumVersionForCollab = defaultMinVersionForCollab;
8184

8285
constructor(

0 commit comments

Comments
 (0)